search

Devasy23 / FaceRec

An advanced facial recognition system designed for real-time identification using deep learning models and optimized vector search. Features include face detection, embedding generation, and scalable deployment options.
Apache License 2.0
32 stars 30 forks source link

Improve Multithreading Implementation in MAIN.PY #60

Open Kishore007raj opened 1 month ago

Kishore007raj commented 1 month ago

Bug I found: The current implementation of the multithreading logic in main.py uses a ThreadPoolExecutor to run both the FastAPI and Flask applications simultaneously

Identified Issues : Some of the Issues I found were a Lack of Error Handling; resource management and also code readability.

Proposed Improvement: These are the ways we can improve the multithreading function: (1).implementing a try-except Error Handling (2): Enhance Code Clarity

By addressing these issues and implementing the proposed improvements, the multithreading functionality in main.py can be made more robust, reliable, and maintainable. Please consider this issue for further discussion and contributions!

devansh-shah-11 commented 1 month ago

Yep sure - go ahead and fix it up :)

Kishore007raj commented 1 month ago

sure!!