search

Devdre1909 / tip-calculator

Frontend Mentors Challenge solution to the tip calculator design
MIT License
0 stars 2 forks source link

style.css #1

Open Sylvestered opened 2 years ago

Sylvestered commented 2 years ago

Didnt close down your @media... in your css boss, will the style take effect??

Devdre1909 commented 2 years ago

Hi @Sylvestered, it was probably a mistake. Can you fit it and create a PR?

Sylvestered commented 2 years ago

Sir Temitope, can actually fix it up because you taught me well boss lol... Create a PR? I don't understand oo I'm actually one of your students at Future Academy And I'll please like to ask for a favour, I'm not quite understanding the JS part of your lectures... The html and CSS part was superb Thanks boss.... Sylvester

On Tue, 21 Jun 2022, 16:14 Adegoke Temitope, @.***> wrote:

Hi @Sylvestered https://github.com/Sylvestered, it was probably a mistake. Can you fit it and create a PR?

— Reply to this email directly, view it on GitHub https://github.com/Devdre1909/tip-calculator/issues/1#issuecomment-1161900192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIXVEOXV2SZS3AD3FRIPADVQHL5VANCNFSM5ZKPQ3EA . You are receiving this because you were mentioned.Message ID: @.***>

Devdre1909 commented 2 years ago

Hi @Sylvestered

PR is short for Pull Request, it is something people do on an open-source project when they make changes to the project on their personal PC and want to add it up (merge) to the actual project.

You can check out this video for more details Click Here

About the JavaScript, sorry about that. JavaScript has a higher learning curve as compared to HTML and CSS. While watching the videos do well to search about any specific part you didn't understand.

Sylvestered commented 2 years ago

Thanks, I'll check it out.

On Wed, 22 Jun 2022, 08:29 Adegoke Temitope, @.***> wrote:

Hi @Sylvestered https://github.com/Sylvestered

PR is short for Pull Request, it is something people do on an open-source project when they make changes to the project on their personal PC and want to add it up (merge) to the actual project.

You can check out this video for more details Click Here https://www.youtube.com/watch?v=8A4TsoXJOs8

About the JavaScript, sorry about that. JavaScript has a higher learning curve as compared to HTML and CSS. While watching the videos do well to search about any specific part you didn't understand.

— Reply to this email directly, view it on GitHub https://github.com/Devdre1909/tip-calculator/issues/1#issuecomment-1162748974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZIXVENIRW2ICIZJFE6OWNLVQK6D3ANCNFSM5ZKPQ3EA . You are receiving this because you were mentioned.Message ID: @.***>