search

Develatio / django-walletpass

Django .pkpass build, sign, push for updates, serve and more...
Other
23 stars 12 forks source link

add django test matrix #40

Closed patroqueeet closed 1 month ago

patroqueeet commented 1 month ago

due to related Django settings deprecation in v4.2 let's ensure all versions keep working

addresses #32

patroqueeet commented 1 month ago

@alexandernst @NachE ready to merge. good of you?

NachE commented 1 month ago

are these changes enough to consider django 5 supported? /cc @alexandernst

patroqueeet commented 1 month ago

are these changes enough to consider django 5 supported? /cc @alexandernst

I believe so. At least tests pass. Haven't run it in PROD env yet.

alexandernst commented 1 month ago

Up to Django 4.2 it wasn't possible to have multiple storages (not in an easy way). Starting with 4.2 django encourages users to actually use multiple storages, that's why we shouldn't asume the default storage. This should be configurable somehow. Maybe WALLETPASS['STORAGE_BACKEND'] = '<str>'?

patroqueeet commented 1 month ago

STORAGE_BACKEND

see 4f7df0c. good of for you?

patroqueeet commented 1 month ago

@NachE @alexandernst good to merge? any improvements reasonable?

alexandernst commented 1 month ago

I think we're good! Feel free to merge 🙏