DevelopFreedom / logmein-android

Automatically login to University WiFi with your Android
https://play.google.com/store/apps/details?id=org.developfreedom.logmein
GNU General Public License v3.0
16 stars 11 forks source link

wifi state changed #12

Closed Ashish-Bansal closed 9 years ago

Ashish-Bansal commented 9 years ago

Hi Yesterday I got to know about this app from google+. BTW Nice app :)

But I didn't like the option of persistent Notification. I don't think anyone would like to make them persistent. Just a personal opinion, Never mind. Instead better option show up the notification ONLY if WiFi state changed to ON, ssid is PU@CAMPUS and we are not getting redirected anymore i.e. user is already logged in. I would like to add it If it is fine with you.

Regards Ashish Bansal

ylogx commented 9 years ago

Awesome. Go on. We'll need extra WiFi state permission. Rest is just a junior job to add flag in shownotification function inside network engine. I have some more task in line once you finish this :p

On Wednesday, October 22, 2014, Ashish Bansal (mr.phantom) < notifications@github.com> wrote:

Hi Yesterday I got to know about this app from google+. BTW Nice app :)

But I didn't like the option of persistent Notification. I don't think anyone would like to make them persistent. Just a personal opinion, Never mind. Instead better option show up the notification ONLY if WiFi state changed to ON, ssid is PU@CAMPUS and we are not getting redirected anymore i.e. user is already logged in. I would like to add it If it is fine with you.

Regards Ashish Bansal

Reply to this email directly or view it on GitHub https://github.com/DevelopFreedom/logmein-android/issues/12.

Regards, Shubham Chaudhary (UTC +05:30) http://www.shubhamchaudhary.in

ylogx commented 9 years ago

Resolved with 320b2abbcef98f063ad77f71faeb4a19066efb4f Great Job.