Closed diegoalzate closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
π Inspect: https://vercel.com/developdao/dao-job-board/5ytcsqcrxCAtx2kwHbJHr7kGVKGK
β
Preview: https://dao-job-board-git-feature-add-profile-image-developdao.vercel.app
@allcontributors please add @diegoalzate for code
@carlomigueldy
I've put up a pull request to add @diegoalzate! :tada:
Looks good overall thank you @diegoalzate π
I've requested some minor changes. But I also noticed that
yarn.lock
was removed andpackage-lock.json
is added, I am not entirely sure if this is a problem but would like to request your review π on this PR @with-heart @Dhaiwat10
@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)
Looks good overall thank you @diegoalzate π I've requested some minor changes. But I also noticed that
yarn.lock
was removed andpackage-lock.json
is added, I am not entirely sure if this is a problem but would like to request your review π on this PR @with-heart @Dhaiwat10@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)
Yo @diegoalzate ! Just delete all package-lock.json
files and run yarn install
this creates the yarn.lock
files. Then that should be it for the quick fix.
And then we're ready to merge this in!
Looks good overall thank you @diegoalzate π I've requested some minor changes. But I also noticed that
yarn.lock
was removed andpackage-lock.json
is added, I am not entirely sure if this is a problem but would like to request your review π on this PR @with-heart @Dhaiwat10@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)
Yo @diegoalzate ! Just delete all
package-lock.json
files and runyarn install
this creates theyarn.lock
files. Then that should be it for the quick fix.And then we're ready to merge this in!
@carlomigueldy sounds great, just pushed these changes, not sure why it says i dismissed @Dhaiwat10 stale review :/
Looks good overall thank you @diegoalzate π I've requested some minor changes. But I also noticed that
yarn.lock
was removed andpackage-lock.json
is added, I am not entirely sure if this is a problem but would like to request your review π on this PR @with-heart @Dhaiwat10@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)
Yo @diegoalzate ! Just delete all
package-lock.json
files and runyarn install
this creates theyarn.lock
files. Then that should be it for the quick fix. And then we're ready to merge this in!@carlomigueldy sounds great, just pushed these changes, not sure why it says i dismissed @Dhaiwat10 stale review :/
Whoops sorry, I think it was the branch rules that I put. I removed that rule instead so it doesn't get dismissed unintentionally
Overview
This PR adds an upload profile image functionality to the create-profile page ISSUE
In order to create this i installed the following packages:
How the AddAvatar component works
Firstly, i checked the supabase client and hooks were being created, very cool btw. So i followed that arcihtecture and stored the web3StorageClient in the common folder
note: this whole functionality requires a web3Storage token to be added to doppler, as of right now this token is associated to my account, ill leave this up to you guys @carlomigueldy @angeljgomezc @Dhaiwat10
AddAvatarComponent
This component recieves a src as a prop which will be the image that is rendered initially.
hoverImage
.hoverImage
changes with thetoggleHover
function that is triggered by the eventsonMouseLeave
while it is a div with a background image andonMouseEnter
while it is just an image component, in order to show a button while mouse is over the image and remove it when it is no longer there.submitProfilePicture
, this function shows what we send to web3Storage and what they return, i added a todo so the result is updated in db