Developer-DAO / DAO-job-board

A job board connecting DAOs with talent.
https://devdao-job-board.vercel.app/
82 stars 34 forks source link

add profile image #139

Closed diegoalzate closed 2 years ago

diegoalzate commented 2 years ago

Overview

This PR adds an upload profile image functionality to the create-profile page ISSUE

In order to create this i installed the following packages:

How the AddAvatar component works

Firstly, i checked the supabase client and hooks were being created, very cool btw. So i followed that arcihtecture and stored the web3StorageClient in the common folder

import { Web3Storage } from 'web3.storage';

export const makeStorageClient = () => {
  return new Web3Storage({ token: process.env.WEB3STORAGE_TOKEN ?? '' });
};

note: this whole functionality requires a web3Storage token to be added to doppler, as of right now this token is associated to my account, ill leave this up to you guys @carlomigueldy @angeljgomezc @Dhaiwat10

AddAvatarComponent

This component recieves a src as a prop which will be the image that is rendered initially.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/developdao/dao-job-board/5ytcsqcrxCAtx2kwHbJHr7kGVKGK
βœ… Preview: https://dao-job-board-git-feature-add-profile-image-developdao.vercel.app

carlomigueldy commented 2 years ago

@allcontributors please add @diegoalzate for code

allcontributors[bot] commented 2 years ago

@carlomigueldy

I've put up a pull request to add @diegoalzate! :tada:

diegoalzate commented 2 years ago

Looks good overall thank you @diegoalzate πŸŽ‰

I've requested some minor changes. But I also noticed that yarn.lock was removed and package-lock.json is added, I am not entirely sure if this is a problem but would like to request your review πŸ‘€ on this PR @with-heart @Dhaiwat10

@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)

carlomigueldy commented 2 years ago

Looks good overall thank you @diegoalzate πŸŽ‰ I've requested some minor changes. But I also noticed that yarn.lock was removed and package-lock.json is added, I am not entirely sure if this is a problem but would like to request your review πŸ‘€ on this PR @with-heart @Dhaiwat10

@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)

Yo @diegoalzate ! Just delete all package-lock.json files and run yarn install this creates the yarn.lock files. Then that should be it for the quick fix.

And then we're ready to merge this in!

diegoalzate commented 2 years ago

Looks good overall thank you @diegoalzate πŸŽ‰ I've requested some minor changes. But I also noticed that yarn.lock was removed and package-lock.json is added, I am not entirely sure if this is a problem but would like to request your review πŸ‘€ on this PR @with-heart @Dhaiwat10

@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)

Yo @diegoalzate ! Just delete all package-lock.json files and run yarn install this creates the yarn.lock files. Then that should be it for the quick fix.

And then we're ready to merge this in!

@carlomigueldy sounds great, just pushed these changes, not sure why it says i dismissed @Dhaiwat10 stale review :/

carlomigueldy commented 2 years ago

Looks good overall thank you @diegoalzate πŸŽ‰ I've requested some minor changes. But I also noticed that yarn.lock was removed and package-lock.json is added, I am not entirely sure if this is a problem but would like to request your review πŸ‘€ on this PR @with-heart @Dhaiwat10

@carlomigueldy True i didnt notice that I removed the yarn.lock, i did a back merge to fix conflicts with the new changes that were uploaded to main but something obviously went wrong along the way. Just let me know how i should fix it :)

Yo @diegoalzate ! Just delete all package-lock.json files and run yarn install this creates the yarn.lock files. Then that should be it for the quick fix. And then we're ready to merge this in!

@carlomigueldy sounds great, just pushed these changes, not sure why it says i dismissed @Dhaiwat10 stale review :/

Whoops sorry, I think it was the branch rules that I put. I removed that rule instead so it doesn't get dismissed unintentionally