Developer-DAO / DAO-job-board

A job board connecting DAOs with talent.
https://devdao-job-board.vercel.app/
82 stars 34 forks source link

refactor: implements new JobCard design #162

Closed krames12 closed 2 years ago

krames12 commented 2 years ago

Description

This PR takes the new Job Card design from the Job Board Figma File.

Linked Issue: #155

Notes

Validation Steps

  1. navigate to /jobs
  2. Verify that you see the new <JobCard /> design image
  3. Click on the heart icon to "un-favorite" the job image
  4. Verify that the icon is no longer filled and there is a color change image
vercel[bot] commented 2 years ago

@krames12 is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/developdao/dao-job-board/FHMBr1F12HrCUMdjjMuozxGy4sGD
✅ Preview: Failed

Dhaiwat10 commented 2 years ago

Vercel logs:

image

christiananese commented 2 years ago

With the new design in place I think it would make sense to require adding stories for storybook for each new component. It makes definitely more sense to add them when developing a new component and not later on. @angeljgomezc @carlomigueldy @frankTurtle what do you think?

krames12 commented 2 years ago

@Dhaiwat10 Ty for showing those logs since I'm unable to see the deploys (which is probably for the best considering it's my first PR 😅). I thought I had fixed that but apparently not.

@christiananese Will definitely add stories to Storybook! I didn't notice we have it in my haste to get started on this issue.