Developer-DAO / DAO-job-board

A job board connecting DAOs with talent.
https://devdao-job-board.vercel.app/
82 stars 34 forks source link

Added Button Stories + New Colors from Design #166

Closed 4gnle closed 2 years ago

4gnle commented 2 years ago

This PR brings the new buttons using the colors from the design system at https://www.figma.com/file/qGlR5rEinlbUgWmbogXunz/Design-System-%2F-Jobs-Board?node-id=119%3A10

The Buttons have a problem, though - they don't show on Storybook

vercel[bot] commented 2 years ago

@angeljgomezc is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

with-heart commented 2 years ago

I think we should take this opportunity to move away from custom button components entirely and instead utilize Chakra's component style system to capture the shared base button styles and implement the stylistic differences between these buttons.

The purpose of this system is to allow complete customization of any components while requiring that users become familiar with only a single component+props api:

const Current = () => (
  <>
    <ButtonInfo>Click Me</ButtonInfo>
    <ButtonNeutral>Click Me</ButtonNeutral>
    <ButtonWarning>Click Me</ButtonNeutral>
  </>
)

// VS.

const WithComponentStyle = () => (
  <>
    <Button colorScheme="info">Click Me</Button>
    <Button colorScheme="neutral">Click Me</Button>
    <Button colorScheme="warning">Click Me</Button>
  </>
)

Happy to add more details/examples of what this change might look like here, or I can open an issue if we'd rather make that change as a follow-up!

with-heart commented 2 years ago

Actually imo after thinking about it, I think we should break this PR up into two separate PRs:

  1. adding + documenting the new colors

    we should build something similar to Chakra's colors docs for our Storybook

    image

  2. converting the buttons to use the new colors