search

Developer-DAO / DAO-job-board

A job board connecting DAOs with talent.
https://devdao-job-board.vercel.app/
82 stars 34 forks source link

Add JobPreview / Standardize default page margins / Convert NavBar to grid / General CSS standardisation adjustments #191

Closed manapixels closed 2 years ago

manapixels commented 2 years ago

  1. Added JobPreview:

    Screenshot 2022-01-04 at 12 22 45 PM

  2. Reduced padding on JobCard to match wireframe more accurately

  3. Decomposed content within links in JobCard for reusability in JobPreview and future components

vercel[bot] commented 2 years ago

@zhenyangg is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

carlomigueldy commented 2 years ago

Hey awesome stuff man @zhenyangg thanks for contributing! 🤝 Would love to get some context like which Figma designs you were basing this off, or which issue was it? You can mention the issue from the description btw.

carlomigueldy commented 2 years ago

@allcontributors please add @zhenyangg for code!

allcontributors[bot] commented 2 years ago

@carlomigueldy

I've put up a pull request to add @zhenyangg! :tada:

manapixels commented 2 years ago

Hey awesome stuff man @zhenyangg thanks for contributing! 🤝 Would love to get some context like which Figma designs you were basing this off, or which issue was it? You can mention the issue from the description btw.

Here's the issue: https://github.com/Developer-DAO/DAO-job-board/issues/190 Worked on: JobPreview component (right side of the screen) and the screenshot from Figma: IN PROGRESS - Jobs board - Create New Job v1

manapixels commented 2 years ago

More updates:

  1. Replaced sidebar fontawesome icons with tabler icons
  2. Adjusted sidebar paddings to reflect new design changes
  3. Added 'Create new job' button and discord link

Update preview (shadow not included

Screenshot 2022-01-06 at 6 20 57 PM
PBillingsby commented 2 years ago

@carlomigueldy how do we get this deployed so I can test the PR app?

carlomigueldy commented 2 years ago

@carlomigueldy how do we get this deployed so I can test the PR app?

Oh, about that we can't authenticate it via Vercel since we aren't part of Vercel Team.

Unsure if @angeljgomezc is already part of Developer DAO Vercel team though.

4gnle commented 2 years ago

@carlomigueldy how do we get this deployed so I can test the PR app?

Oh, about that we can't authenticate it via Vercel since we aren't part of Vercel Team.

Unsure if @angeljgomezc is already part of Developer DAO Vercel team though.

I haven't checked this yet because I'm looking for a way to gain access to the Vercel or get a Vercel sponsorship before moving forward

It's cool to review code and stuff, but having our PRs deployed would be much better - so I'm waiting for that before merging any front-end code without a preview

PBillingsby commented 2 years ago

@zhenyangg Need these conflicts resolved and I will test

manapixels commented 2 years ago

@zhenyangg Need these conflicts resolved and I will test

conflicts resolved.

manapixels commented 2 years ago
  1. I'm using the existing components. Have been adding on to the chakra ui variants as well when necessary
  2. Reviewed and updated.
manapixels commented 2 years ago

Mobile breakpoints added for JobPreview, NavBar, and PostJob page (post-job > index.tsx

Screenshot 2022-01-06 at 6 20 57 PM Screenshot 2022-01-11 at 2 44 47 PM Screenshot 2022-01-11 at 3 05 35 PM Screenshot 2022-01-11 at 3 05 29 PM

)

manapixels commented 2 years ago
  1. Standardized margins across all existing pages
  2. Fix hover behaviour; changed margin to transform on DeveloperItem & JobCard hovers
  3. Reduced DeveloperItem & JobCard hover on y-axis
  4. Hide "+ Create new job" button except for hirers
vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/devdaojobboard/dao-job-board/9qyCanpJ2eGwVNUg3XoHVx8P4DQi
✅ Preview: https://dao-job-board-git-fork-zhenyangg-main-devdaojobboard.vercel.app

4gnle commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/devdaojobboard/dao-job-board/6btjDL5XUHbhTjScKfKVLn7zegzx ✅ Preview: https://dao-job-board-git-fork-zhenyangg-main-devdaojobboard.vercel.app

Hey @zhenyangg ! The changes look awesome - just checked the preview and there are still a few things to polish:

  1. The input for changing user mode has a border/outline on focus. Can you get rid of that? It looks awkward. image

  2. Also, the select shouldn't show a placeholder. You can check the current deployment from https://devdao-job-board.vercel.app/ to have an idea. I'm afraid you may need to rebase/pull from the repo in that case, so these changes don't get pushed into the main branch.

  3. The JobPost modal in the JobList page doesn't open, it goes directly into the job page. We're trying to make it different, like this: https://devdao-job-board.vercel.app/jobs (click on a job so you can see).

Apart from that, all changes look good. We're all happy with your contributions - thank you!

manapixels commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit. 🔍 Inspect: https://vercel.com/devdaojobboard/dao-job-board/6btjDL5XUHbhTjScKfKVLn7zegzx ✅ Preview: https://dao-job-board-git-fork-zhenyangg-main-devdaojobboard.vercel.app

Hey @zhenyangg ! The changes look awesome - just checked the preview and there are still a few things to polish:

  1. The input for changing user mode has a border/outline on focus. Can you get rid of that? It looks awkward. image
  2. Also, the select shouldn't show a placeholder. You can check the current deployment from https://devdao-job-board.vercel.app/ to have an idea. I'm afraid you may need to rebase/pull from the repo in that case, so these changes don't get pushed into the main branch.
  3. The JobPost modal in the JobList page doesn't open, it goes directly into the job page. We're trying to make it different, like this: https://devdao-job-board.vercel.app/jobs (click on a job so you can see).

Apart from that, all changes look good. We're all happy with your contributions - thank you!

  1. Reset to original.
  2. Removed placeholder.
  3. Fixed expected behaviour of modal.
4gnle commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit. 🔍 Inspect: https://vercel.com/devdaojobboard/dao-job-board/6btjDL5XUHbhTjScKfKVLn7zegzx ✅ Preview: https://dao-job-board-git-fork-zhenyangg-main-devdaojobboard.vercel.app

Hey @zhenyangg ! The changes look awesome - just checked the preview and there are still a few things to polish:

  1. The input for changing user mode has a border/outline on focus. Can you get rid of that? It looks awkward. image
  2. Also, the select shouldn't show a placeholder. You can check the current deployment from https://devdao-job-board.vercel.app/ to have an idea. I'm afraid you may need to rebase/pull from the repo in that case, so these changes don't get pushed into the main branch.
  3. The JobPost modal in the JobList page doesn't open, it goes directly into the job page. We're trying to make it different, like this: https://devdao-job-board.vercel.app/jobs (click on a job so you can see).

Apart from that, all changes look good. We're all happy with your contributions - thank you!

1. Reset to original.

2. Removed placeholder.

3. Fixed expected behaviour of modal.

AWESOME WORK! Thank you!

manapixels commented 2 years ago

yay first commit to main :)