search

Developer-DAO / DAO-job-board

A job board connecting DAOs with talent.
https://devdao-job-board.vercel.app/
82 stars 34 forks source link

Adding Profile Image/Avatar #60

Closed 4gnle closed 2 years ago

4gnle commented 2 years ago

Every user will have the chance to change their PFP through the Profile Form

We have the mockup for the profile form, but we should still add the input so users can add the image they prefer and upload it. We need a mockup for this input (feel free to propose something via Figma + push a PR to the repo afterward)

Here's the create-profile file. The add-avatar component should rest on the create-profile folder in components

I think we could use Fleek's file storage to store these pictures then add them to the database only as URLs (this will make them slower to fetch, given IPFS slowness), but makes the website more web3 friendly in the process.

What do you guys think? @carlomigueldy @with-heart @JoviDeCroock @swetshaw @Dhaiwat10 @miralsuthar @frankTurtle

diegoalzate commented 2 years ago

Hey, i think i can give this a shot :)

carlomigueldy commented 2 years ago

I think we could use Fleek's file storage to store these pictures then add them to the database only as URLs (this will make them slower to fetch, given IPFS slowness), but makes the website more web3 friendly in the process.

Hey for the storage, I got one in mind and it's pretty simple to use it. It's IPFS + FileCoin together for persistence.

Web3 Storage -> https://web3.storage/

Dhaiwat10 commented 2 years ago

We def need this. Good luck @diegoalzate and feel free to ask for help

diegoalzate commented 2 years ago

I think i finished the basic functionalities, but i have some doubts.

carlomigueldy commented 2 years ago

Awesome stuff Diego thanks so much for the contribution! 💯

First of all i created a web3Storage account with my github account and generated an api key with that account, I'm not sure if we should create this api key with another account

Do we use a Developer DAO account for this? Or an account that's specifically for the Job Board project @with-heart @angeljgomezc @Dhaiwat10

Another doubt is concerning an update functionality with web3Storage, i can successfully store a file but i havent been able to see how i can update an existing file directory.

I'm not that experienced with Web3Storage (IPFS), we can probably go for is to upload a new file in a different path, however that would take up some space for the free 1 TB Web3Storage provides on the free tier. But would like to know if uploading existing files on IPFS is possible @angeljgomezc @Dhaiwat10

Lastly, not sure how to structure the PR so everything is explained in a clear and consice way, not sure if theres like a convention or guide to do that properly

I am gonna take a look at some templates for the pull requests in its most simplest form so everyone that creates a pull request will have a guide on what information to put

diegoalzate commented 2 years ago

@carlomigueldy @Dhaiwat10 @angeljgomezc Hi! I'm still a bit stuck on this, not sure if the database connection changes the way this feature should work.

4gnle commented 2 years ago

Hey @diegoalzate, where are you stuck exactly? The database isn't finished yet, so you probably shouldn't worry about that. As long as you can set up upload to IPFS and you get the link of the file being uploaded, that should be enough.

Also, a simple UI would suffice for this job (takes the new profile form as a guide).

carlomigueldy commented 2 years ago

@carlomigueldy @Dhaiwat10 @angeljgomezc Hi! I'm still a bit stuck on this, not sure if the database connection changes the way this feature should work.

Yo, if you're directly integrating this and adding actual record to database, the attribute avatar_url from users table is up-to-date. However if not the case then you can add TODOs that the returned value for the IPFS upload needs to be saved into the database.

4gnle commented 2 years ago

closed via #139