search

Developer-DAO / academy-t3-app-router

Academy T3 app router migration + rainbowkit 2 + wagmi 2 + next-auth 4
https://academy-t3-app-router.vercel.app
3 stars 1 forks source link

SEO Review #15

Open kempsterrrr opened 3 months ago

kempsterrrr commented 3 months ago

WIP TODOs:

questions:

  1. Why are we rendering pages like tracks and fundamentals on the client? Could these be server-rendered or statically generated, as this would be helpful with SEO, Speed and indexing?
kempsterrrr commented 3 months ago

OK, it looks like the issue in the second point about pages being rendered is that we're rendering them on the client. The same issue is present on the production academy site. If we can solve that on this new version with SSG/SSR rendering those pages, that would be great for SEO/UX/Performance, etc.

kempsterrrr commented 2 months ago

@Markkos89 sitemap is looking niiiiiiiice, good work. Quick fix needed on this, there are double slashes appearing in some of the URLs in the sitemap.xml file here

image

Markkos89 commented 2 months ago

@Markkos89 sitemap is looking niiiiiiiice, good work. Quick fix needed on this, there are double slashes appearing in some of the URLs in the sitemap.xml file here

image

Alright, fixed it on https://github.com/Developer-DAO/academy-t3-app-router/pull/17

:muscle:

kempsterrrr commented 2 months ago

amazing shipping @Markkos89 letsssgoooo

Markkos89 commented 2 months ago

amazing shipping @Markkos89 letsssgoooo

Thanks kemps! :raised_hands:

Can you check again if every page is being indexed now? :thinking: :pray:

Thanks in advance!

Markkos89 commented 2 months ago

@kempsterrrr quick question, just to be sure, this is the desired favicon? :thinking:

image

in case is not, can you please let me know which one?

kempsterrrr commented 2 months ago

amazing shipping @Markkos89 letsssgoooo

Thanks kemps! 🙌

Can you check again if every page is being indexed now? 🤔 🙏

Thanks in advance!

I think this is working ok, tools seem to be recognising the sitemap however as the pages are rendered with JavaScript the tool isn't crawling them because I need the very expensive paid version to do that. I think this is fine to ship as is and will make a note to look into it later this week when I have a little more time to see if can figure it out.,

in case is not, can you please let me know which one?

these are the correct ones yes, although use the square logo for the favicon as they show as squares in the browser.

kempsterrrr commented 2 months ago

@Markkos89 I noticed the 404 page wasn't working so added that as a todo item on here.

How are you getting on with the other items? What else do you still need from me?

Markkos89 commented 1 month ago

How are you getting on with the other items? What else do you still need from me?

I will write down the status of each remaining list item below @kempsterrrr Just wondering if we are putting a lot on this SEO stuff when it can be done having the t3-app-router version online.

SEO TODOs status:

  • [ ] Only /, /tracks & /fundamentals are being indexed when crawled. all pages need to be indexed. I'm unsure what is causing this yet but am asking an SEO friend

Regarding indexing I'm waiting an update from you. Last thing was that the app tool is very expensive to check other pages. How are you testing this? If you can tell me what to do I can do the testing just for the sake of moving forward.

This is solved with the latest update of dynamic segment (dynamic routes)

  • [ ] ensure URLs are using - "dashes" in between words not _ underscores, example for CLI Lesson using underscores - https://academy-t3-app-router.vercel.app/fundamentals/cli_lesson

This is something I leaving for later because it's something really small to do but if I change the database data will affect our production environment from academy-turbo.

i will add it.

kempsterrrr commented 1 month ago

Nice work!

All I'm doing to check for the first point is running it through this tool which scrapes the site to check for SEO errors.

Ideally we want to it pick up all the pages in the site. If the changes moved us away from client rendering they should show up in the crawl report. Only need paid version to crawl for client rendered pages which we're hoping to avoid.

Ticked of the second one

Makes sense re ULR changes, thanks for letting me know.

Sounds good re 404

kempsterrrr commented 1 month ago

In support of getting app router version live asap, these bits (minus the dashes vs underscores) get us there.

Markkos89 commented 1 month ago

@kempsterrrr FYI I still have to create the content creators/authors/contributors registries in the database because it's going to be fetched dinamically. Can you help me gather all the information for all the contributors?

we have some info in the contributors.ts file but maybe there is something left there so if you could gather all the info from the .mdx files that would be awesome mate :raised_hands:

The goal is to populate this table:

image

I left some notes in the code of where is going to be used

Markkos89 commented 1 month ago

@kempsterrrr PR #21 is merged. Now the sitemap.ts will generate the sitemap.xml with this project domain URL https://academy-t3-app-router.vercel.app/. screenshot: image with this change deployed now we have to check if the pages are being indexed, etc (item number 2 from the TODO list) I will take care of that.

The 404 page was added. I ticked the 404 page item from the list. The only item remaining is the one related to the dashes on the Lesson path. We are good.

kempsterrrr commented 1 month ago

Excellent work, @Markkos89 ! I confirmed the pages are being crawled now 👏👏

Running the test did highlight a few other issues we need to work on for SEO, but they shouldn't be a blocker for getting this new version live, as these issues exist on the current site. I'll make a note to open another issue so we can track these as well; straightforward fixes could be excellent first issues for folks or easily added to another future PR.

@wolovim, can you help gather the info for content creators, please?

Markkos89 commented 1 month ago

Excellent work, @Markkos89 ! I confirmed the pages are being crawled now 👏👏

Awesome!! Thanks @kempsterrrr

@wolovim, can you help gather the info for content creators, please?

@kempsterrrr @wolovim I will be working on this tomorrow :muscle: