Developer-DAO / academy-turbo

D_D Academy is an open-source education platform created by and for Developer DAO.
https://academy.developerdao.com
MIT License
17 stars 10 forks source link

feat: more buttons styling across app #152

Closed Markkos89 closed 7 months ago

Markkos89 commented 7 months ago

Changes

this closes #139 and #142 and #150

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 4:09am
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **academy-turbo** | ⬜️ Ignored ([Inspect](https://vercel.com/developdao/academy-turbo/FqiRQGHc9K5vSgMJSF3dnRYq6e63)) | [Visit Preview](https://academy-turbo-git-feat-quiz-buttons-styling-developdao.vercel.app) | | Feb 8, 2024 4:09am |
github-actions[bot] commented 7 months ago

Running Lighthouse audit...

Markkos89 commented 7 months ago

looks like a good iteration; the styles are getting closer. after completing a quiz though, i'm not seeing the updated state 🤔 i.e., quiz button remains

yeah, I have to review the functionality now. Can we merge it and I can create a new ticket for it?

Markkos89 commented 7 months ago

looks like a good iteration; the styles are getting closer. after completing a quiz though, i'm not seeing the updated state 🤔 i.e., quiz button remains

yeah, I have to review the functionality now. Can we merge it and I can create a new ticket for it?

@wolovim I created #154

Markkos89 commented 7 months ago

merged #153 here.

now this closes #150

elPiablo commented 7 months ago

@uma-l @Markkos89

Thanks for the work on this.

It's interesting to experience buttons for LessonQuestionsModal and LessonInformationalModal in the centre of the page. I always wondered what this change would look like (I thought that all the buttons on the left of the page was maybe not a great idea)

LessonQuestionsModal seems to be rendering with the intended text and font - but I personally experience this combination of font (choice, boldness, uppercase), the intensity of purple, and the shape/size of the button (quite big) to be very distracting - like a big neon light in the middle of the page, when you're trying to focus and learn.

A couple of suggestions to make this easier on the experience:

LessonInformationalModal isn't rendering. I left some notes: https://github.com/Developer-DAO/academy-turbo/pull/152/files#r1483102285