Closed Markkos89 closed 7 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
academy-turbo-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 8, 2024 4:09am |
Running Lighthouse audit...
looks like a good iteration; the styles are getting closer. after completing a quiz though, i'm not seeing the updated state 🤔 i.e., quiz button remains
yeah, I have to review the functionality now. Can we merge it and I can create a new ticket for it?
looks like a good iteration; the styles are getting closer. after completing a quiz though, i'm not seeing the updated state 🤔 i.e., quiz button remains
yeah, I have to review the functionality now. Can we merge it and I can create a new ticket for it?
@wolovim I created #154
merged #153 here.
now this closes #150
@uma-l @Markkos89
Thanks for the work on this.
It's interesting to experience buttons for LessonQuestionsModal and LessonInformationalModal in the centre of the page. I always wondered what this change would look like (I thought that all the buttons on the left of the page was maybe not a great idea)
LessonQuestionsModal seems to be rendering with the intended text and font - but I personally experience this combination of font (choice, boldness, uppercase), the intensity of purple, and the shape/size of the button (quite big) to be very distracting - like a big neon light in the middle of the page, when you're trying to focus and learn.
A couple of suggestions to make this easier on the experience:
LessonInformationalModal isn't rendering. I left some notes: https://github.com/Developer-DAO/academy-turbo/pull/152/files#r1483102285
Changes
this closes #139 and #142 and #150