search

Developer-DAO / academy-turbo

D_D Academy is an open-source education platform created by and for Developer DAO.
https://academy.developerdao.com
MIT License
18 stars 10 forks source link

Staging to Main: v2 MVP release #185

Closed Markkos89 closed 8 months ago

Markkos89 commented 8 months ago

v2 MVP release

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 11:59pm
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 11:59pm
github-actions[bot] commented 8 months ago

Running Lighthouse audit...

elPiablo commented 8 months ago

You must be tired of debugging at this stage, but there are still a couple of bugs when choosing a wallet: I have zerion and MM browser extensions, but when I choose MM from Academy app, it returns the Zerion option only. Otherwise I have to force it manually to go to MM:

chooseMM-getZerion

Obviosly, if MM is the only browser extension, it will choose MM.

the style of the 'send message' button is difficlut to see - as a result, it's easy to miss this step -which means getting acccess to and being able to do the quiz, but then your results won't get logged (I fell into this trap a few times already simply becasue of that button: sendMessageButtonIsTooDifficultTooSee

Markkos89 commented 8 months ago

You must be tired of debugging at this stage, but there are still a couple of bugs when choosing a wallet: I have zerion and MM browser extensions, but when I choose MM from Academy app, it returns the Zerion option only. Otherwise I have to force it manually to go to MM:

chooseMM-getZerion

Obviosly, if MM is the only browser extension, it will choose MM.

And which would be the desired behaviour? Can you record a small video reproducing the issue?

As far I see in the screenshot, you choosed Metamask and it triggered the metamask extension. So there is nothing wrong there.

One thing to notice, is that if you have Zerion and metamask installed in your browser, by default, zerion starts blocking metamakas extension. I don't know why, I don't know if this is intented or even if this is something "normal" between extensions but with my experience using it that was what I could notice and wanted to let you know so you might test it on your end too.

elPiablo commented 8 months ago

You must be tired of debugging at this stage, but there are still a couple of bugs when choosing a wallet: I have zerion and MM browser extensions, but when I choose MM from Academy app, it returns the Zerion option only. Otherwise I have to force it manually to go to MM:

chooseMM-getZerion

Obviosly, if MM is the only browser extension, it will choose MM.

And which would be the desired behaviour? I was only adding that as context

elPiablo commented 8 months ago

One thing to notice, is that if you have Zerion and metamask installed in your browser, by default, zerion starts blocking metamakas extension. I don't know why, I don't know if this is intented or even if this is something "normal" between extensions but with my experience using it that was what I could notice and wanted to let you know so you might test it on your end too.

I was thinking afterward our convo that it probably defaults to MM if we have imported the MM address into Zerion. So, new test: I'm going to create a new browser profile and a separate MM and a separate Zerion wallet and see how it behaves.

Markkos89 commented 8 months ago

it's a browser extensions issue. Zerion vs Metamask