search

Developer-DAO / academy-turbo

D_D Academy is an open-source education platform created by and for Developer DAO.
https://academy.developerdao.com
MIT License
16 stars 10 forks source link

Feat/email verification flow completed #233

Closed Markkos89 closed 3 months ago

Markkos89 commented 3 months ago

Changes

save button disabled

image

valid email

image

notification

image

email stored in database

image

Next steps

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 0:13am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 0:13am
github-actions[bot] commented 3 months ago
⚡️ Lighthouse report for the changes in this PR: Category Score
🔴 Performance 34
🟢 Accessibility 96
🟠 Best practices 83
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-feat-emailverification-v2-developdao.vercel.app/

notion-workspace[bot] commented 3 months ago

Academy Feat: Emailing users and sybil resistance

Markkos89 commented 3 months ago

Hello guys! Thanks a millon for both inputs! I updated the branch with more work done, the email sent method wasn't pushed before. Now it should work and send it to the email inserted in the input. I have to update the env var for sendgrid. I also updated the database schema with the verificationNumber field wich is a autogenerated random number of 6 digits and stored there so we can validate against it.

Let me know what do you think about the flow or anything. Open to suggestions/ideas.

Next steps would be to mutate the emailVerifed field with the verification Date with a mutation I have to built and that would be it.

Thank you so much!! :raised_hands:

@elPiablo @kempsterrrr @wolovim

:rocket:

kempsterrrr commented 3 months ago

@Markkos89 opened issue re privacy policy as discussed - https://github.com/Developer-DAO/academy-turbo/issues/234

Markkos89 commented 3 months ago

The email validation flow is completed now! With email with verification being sent, verification of the number, and everything stored in database.

cc: @wolovim @elPiablo @kempsterrrr please check it and let's ship it

Markkos89 commented 3 months ago

HEy @Markkos89 Just want to show what the basic user flow is. Here are two scenarios I've tested: Number 1:

  • I have a brand new browser profile, with a brand new wallet at, and I will be using a new email address
  • I open: https://academy-turbo-ktaoi4yeb-developdao.vercel.app/ on that profile and nothing happens.
  • So I click on Academy's CONNECT button => wallet opens, I click on 'Connect' in the wallet => "Verify your Account"/Send message => Sign in and =>
  • I get your modal to "Configrure your email".
  • I fill in email in modal, but i don't get an email notification
  • therefore I can't "Insert the verification Code Sent"

Number 2:

  • I open a well used browser profile, i.e. my 'daily' Brave profile, which has my 'piablo.eth' wallet (I've done loads of quizzes, etc with this wallet) with the URL: https://academy-turbo-ktaoi4yeb-developdao.vercel.app/
  • Nothing happens, so I do the same as above, log into my piablo.eth wallet and sign on to Academy.
  • Important to note, I haven't coupled/paired this wallet to an email address on Academy, but the modal appears asking me to "Insert the verification code Sent"

Can you give some bullet points on 2 or 3 scenarios of the user please? (

  • a brand new user
  • and a user who has a wallet and email successfully coupled to each other
  • and a user such as me, where my wallet is recognised in the database, but I don't have an email yet address attached to it (maybe I'm wasting your time with this 3rd option, and it's not relevant for us all)

Hey Piablo! GM!

Let's check:

Important to note, I haven't coupled/paired this wallet to an email address on Academy, but the modal appears asking me to "Insert the verification code Sent"

you already have email's set up:

image

image

So, @elPiablo are you NOT receiving the verification number email?

elPiablo commented 3 months ago

Hey @Markkos89 !!

So, @elPiablo are you NOT receiving the verification number email?

yes, correct, I don't have email notifications in either (=both for negative sentences) email account

Markkos89 commented 3 months ago

Hey @Markkos89 !!

So, @elPiablo are you NOT receiving the verification number email?

yes, correct, I don't have email notifications in either (=both for negative sentences) email account

have you check the spam folder?

wanna check together? wrote to you on discord

kempsterrrr commented 3 months ago

Hey @Markkos89 - I've just logged in to test this and was shown the code verification modal right away before I was given a chance to enter my email and request the code. I assume this is because I requested a code the first time I tested this flow and was unable to enter it, as when I initially tested this last week, the email didn't arrive. I am, therefore, stuck on this verification screen without any way to fix this as a user.

I suspect this highlights a need for someone to request another verification code (a typical flow in these scenarios) if the initial email doesn't arrive for whatever reasons.

I am stuck on this screen:

image

elPiablo commented 3 months ago

Hey @Markkos89 Scenario 1:

Scenario 2:

Scenario 3:

elPiablo commented 3 months ago

Scenario 3 (resumed):