Closed kempsterrrr closed 3 months ago
vercel[bot]
commented
3 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| academy-turbo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 3, 2024 4:50pm |
| academy-turbo-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 3, 2024 4:50pm |
github-actions[bot]
commented
3 months ago | ⚡️ Lighthouse report for the changes in this PR: | Category | Score |
|---|---|---|
| 🔴 Performance | 31 | |
| 🟢 Accessibility | 96 | |
| 🟠 Best practices | 83 | |
| 🟢 SEO | 92 | |
| 🟠 PWA | 89 |
Lighthouse ran on https://academy-turbo-git-feat-lesson-meta-data-developdao.vercel.app/
Markkos89
commented
3 months ago @kempsterrrr the error comes because you changed the Props of the PageSeoLayout commponent, I will revert it because what you are trying to do, it's already done in the _app.tsx file:
Which is set the default SEO props from the next-seo.config file.
For each Lesson, on the PageSeoLayout, we have to change what is needed only , and it will work :ok_hand:
This WIP PR solves aims to close #218 #217 - opening this draft PR so I can test this is working in a production like environment.