Developer-DAO / academy-turbo

D_D Academy is an open-source education platform created by and for Developer DAO.
https://academy.developerdao.com
MIT License
18 stars 11 forks source link

Revamp landing page #282

Closed rohann06 closed 1 month ago

rohann06 commented 2 months ago

Revamped the landing page UI according to the Figma design

Changes

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 9:00am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 29, 2024 9:00am
vercel[bot] commented 2 months ago

@rohann06 is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot] commented 2 months ago
⚡️ Lighthouse report for the changes in this PR: Category Score
🔴 Performance 34
🟢 Accessibility 98
🟠 Best practices 83
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on undefined

kempsterrrr commented 2 months ago

First PR in, love it @rohann06 - just authorized the deployment and will circle back and take a look later 🫡

If you're free we have the Coordination call for the DAO later @ 3pm UTC in discord. Be good to see you there

rohann06 commented 2 months ago

I will be there 🙌

Markkos89 commented 2 months ago

@rohann06 can you edit the target branch of the PR to staging?

We use to work locally on a feat/ branch and deploy to staging first. Then when releasing we create another PR from staging to main.

Thanks

Markkos89 commented 2 months ago

@rohann06 on every TrackPage and every LessonPage the background image is visible. It should be black background. Can you check? :muscle:

also on the TrackPages there is margin-top or something, check:

image

Markkos89 commented 2 months ago

@rohann06 can you check this margin-left in the homepage? image

it's also present on mobile

image

rohann06 commented 2 months ago

@rohann06 can you check this margin-left in the homepage? image

it's also present on mobile

image

Yess actually, I'm still working on it there are some changes I have to do in lessions page for the footer

Markkos89 commented 2 months ago

gm @rohann06 ! Ca you check FundamentalsPage and TracksPage background?

image

image

I believe it's padding-top or margin-top :)

rohann06 commented 2 months ago

It's not the same on my screen. It might be happening because the last two commits are not deployed maybe.

Screenshot 2024-09-19 at 10 08 47 PM
kempsterrrr commented 2 months ago

Accepted deployment.

Recorded a video to show some strange scroll behaviour I'm seeing - https://www.loom.com/share/2fda5569f551443389c50b4770822a66?sid=fee8c4d3-9b63-4c5f-b8ee-30b45c6d80ac

rohann06 commented 2 months ago

Try this link @kempsterrrr

https://academy-turbo-git-fork-rohann06-revamp-landingpage-developdao.vercel.app/

kempsterrrr commented 2 months ago

Thanks @rohann06 - I'm still seeing the same error. This error exists on the current version of the site, so I'll leave it up to @Markkos89 and @uma-l so I think it would be good to either a) remove the changes on pages other than the home page and ship, or b) accept this is a bug, log it as an issue and ship it or c) move to new layout in Figma for tracks & fundamentals pages which simplifies the view (see video + screenshots from Figma below) a What do you think @Markkos89 @uma-l ?

Video for context: https://www.loom.com/share/c6007a0e7a404cbba5ac028f7b386454?sid=f98a1c4c-dba1-4655-9faf-bbba96e22e41

Screenshot 2024-09-23 at 10 13 27 Screenshot 2024-09-23 at 10 13 40
uma-l commented 1 month ago

@Labzzz , please provide feedback to @rohann06 about the landing page scale issue. thanks

Labzzz commented 1 month ago

@rohann06 just wanted to bring light to this scaling issue that is prevalent on multiple screen sizes. Attaching the implementation vs the design.

Screen Shot 2024-10-09 at 1 06 52 PM

image