Developer-DAO / academy

Deprecated; V2 lives at https://github.com/developer-dao/academy-turbo
https://academy.developerdao.com
110 stars 53 forks source link

intro to eth pt. 2 + 3 #262

Closed wolovim closed 11 months ago

wolovim commented 1 year ago

what does it do?

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 2:34am
wolovim commented 1 year ago

~@Markkos89 @okhaimie-dev @peteruche21 at your convenience, let me know your opinion on the pattern ive used to introduce another track and if youd recommend something different for v1. the camel case URL definitely needs fixing either way (e.g., /lessons/ethIntro/2). warning: my JS knowledge is stale/outdated 😅~

reverted this to keep the PR simpler. can sort out proper track architecture in v2.

elPiablo commented 11 months ago
  • Originally I broke them out into another "track", but v1 doesn't support that architecture well. Abandoned that idea for now and kept the lessons within the fundamentals directory. Punting until v2 to figure out the best home for them.

I would love to see them in a track of their own. Shining!

elPiablo commented 11 months ago

I was surprised that I only got as far as the end of Part 2 tonight, @wolovim 😢

wolovim commented 11 months ago

thanks for thorough review @elPiablo 🖖

ive addressed all feedback with exception of structural updates to the intros. i'll suggest this would be wise to wait until porting over to v2 to optimize for.

wolovim commented 11 months ago

thank you @elPiablo - happy to keep iterating on your few unresolved points in another PR. dont let me forget about em in v2 ;)

elPiablo commented 11 months ago

Hey @wolovim Don't forget to merge into main from staging branch :)