Feat/lesson 5 content's texts update for new code blocks

Developer-DAO / academy

Deprecated; V2 lives at https://github.com/developer-dao/academy-turbo

https://academy.developerdao.com

110 stars 53 forks source link

Feat/lesson 5 content's texts update for new code blocks #282

Closed elPiablo closed 8 months ago

elPiablo commented 8 months ago

My priority is to get this lesson working again

new code blocks added in a separate PR: https://github.com/Developer-DAO/academy/pull/281 (thanks @Markkos89!!)
update the lesson body to match those new pieces of code, and the new steps that a learner needs to take to make them work
at the moment, my intention would be do open a separate and subsequent PR to include quizzes.
If anyone has suggestions for reviewers in D_D that have the bandwidth, and are capable, please, please get in touch with me/us, and we can get them added to the review process.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
academy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 10, 2024 4:04am

elPiablo commented 8 months ago

what a mission. Took me about 3 hours just to simply commit this. 🤯

elPiablo commented 8 months ago

Hey @briangershon I did a general clean-up in there. You're starting off with a messy commit!! I left a lot of comments in the mdx. I totally trust your judgement. Go to town hehe.

Since you actually mentioned V2, would it be possible to simply migrate this PR to https://github.com/Developer-DAO/academy-turbo? I'm not sure what needs to happen for that. cc @Markkos89 ?