search

Developer-DAO / create-dao

MIT License
94 stars 15 forks source link

Unnecessary files are being published to npm #22

Closed Dhaiwat10 closed 2 years ago

Dhaiwat10 commented 2 years ago

We don't need to publish the contents of the template folder let alone stuff like the compiled artifacts of the contracts.

Here are the logs from the last time I ran npm publish:

npm notice 📦  create-dao@1.4.0
npm notice === Tarball Contents === 
npm notice 54B    .prettierrc                                                                                                            
npm notice 733B   CONTRIBUTING.md                                                                                                        
npm notice 1.6kB  README.md                                                                                                              
npm notice 5.8kB  create-app.js                                                                                                          
npm notice 1.2kB  helpers/git.js                                                                                                         
npm notice 2.5kB  helpers/install.js                                                                                                     
npm notice 1.4kB  helpers/is-folder-empty.js                                                                                             
npm notice 905B   helpers/is-online.js                                                                                                   
npm notice 242B   helpers/is-writeable.js                                                                                                
npm notice 166B   helpers/make-dir.js                                                                                                    
npm notice 389B   helpers/should-use-yarn.js                                                                                             
npm notice 480B   helpers/validate-pkg.js                                                                                                
npm notice 2.5kB  index.js                                                                                                               
npm notice 901B   package.json                                                                                                           
npm notice 18.4kB template/cache/solidity-files-cache.json                                                                               
npm notice 277B   template/components/SEO.js                                                                                             
npm notice 1.6kB  template/config.js                                                                                                     
npm notice 251B   template/contracts/ERC20Token.sol                                                                                      
npm notice 561B   template/contracts/Greeter.sol                                                                                         
npm notice 4.0kB  template/contracts/NFT.sol                                                                                             
npm notice 40B    template/eslintrc.json                                                                                                 
npm notice 511B   template/gitignore                                                                                                     
npm notice 883B   template/hardhat.config.js                                                                                             
npm notice 46B    template/next.config.js                                                                                                
npm notice 914B   template/package.json                                                                                                  
npm notice 246B   template/pages/_app.js                                                                                                 
npm notice 1.2kB  template/pages/index.js                                                                                                
npm notice 6.3kB  template/pages/mint.js                                                                                                 
npm notice 690B   template/public/favicon.ico                                                                                            
npm notice 1.1kB  template/public/vercel.svg                                                                                             
npm notice 467B   template/README-template.md                                                                                            
npm notice 1.5kB  template/scripts/deploy.js                                                                                             
npm notice 111B   template/src/artifacts/@openzeppelin/contracts/access/Ownable.sol/Ownable.dbg.json                                     
npm notice 1.3kB  template/src/artifacts/@openzeppelin/contracts/access/Ownable.sol/Ownable.json                                         
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/token/ERC20/ERC20.sol/ERC20.dbg.json                                    
npm notice 28.1kB template/src/artifacts/@openzeppelin/contracts/token/ERC20/ERC20.sol/ERC20.json                                        
npm notice 117B   template/src/artifacts/@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol/IERC20Metadata.dbg.json       
npm notice 4.8kB  template/src/artifacts/@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol/IERC20Metadata.json           
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/token/ERC20/IERC20.sol/IERC20.dbg.json                                  
npm notice 4.0kB  template/src/artifacts/@openzeppelin/contracts/token/ERC20/IERC20.sol/IERC20.json                                      
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/ERC721.sol/ERC721.dbg.json                                 
npm notice 46.0kB template/src/artifacts/@openzeppelin/contracts/token/ERC721/ERC721.sol/ERC721.json                                     
npm notice 117B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol/ERC721Enumerable.dbg.json  
npm notice 8.2kB  template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/ERC721Enumerable.sol/ERC721Enumerable.json      
npm notice 117B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/IERC721Enumerable.sol/IERC721Enumerable.dbg.json
npm notice 7.4kB  template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/IERC721Enumerable.sol/IERC721Enumerable.json    
npm notice 117B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol/IERC721Metadata.dbg.json    
npm notice 7.1kB  template/src/artifacts/@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol/IERC721Metadata.json        
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/IERC721.sol/IERC721.dbg.json                               
npm notice 6.2kB  template/src/artifacts/@openzeppelin/contracts/token/ERC721/IERC721.sol/IERC721.json                                   
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol/IERC721Receiver.dbg.json               
npm notice 990B   template/src/artifacts/@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol/IERC721Receiver.json                   
npm notice 111B   template/src/artifacts/@openzeppelin/contracts/utils/Address.sol/Address.dbg.json                                      
npm notice 748B   template/src/artifacts/@openzeppelin/contracts/utils/Address.sol/Address.json                                          
npm notice 111B   template/src/artifacts/@openzeppelin/contracts/utils/Context.sol/Context.dbg.json                                      
npm notice 244B   template/src/artifacts/@openzeppelin/contracts/utils/Context.sol/Context.json                                          
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/utils/introspection/ERC165.sol/ERC165.dbg.json                          
npm notice 636B   template/src/artifacts/@openzeppelin/contracts/utils/introspection/ERC165.sol/ERC165.json                              
npm notice 114B   template/src/artifacts/@openzeppelin/contracts/utils/introspection/IERC165.sol/IERC165.dbg.json                        
npm notice 638B   template/src/artifacts/@openzeppelin/contracts/utils/introspection/IERC165.sol/IERC165.json                            
npm notice 111B   template/src/artifacts/@openzeppelin/contracts/utils/Strings.sol/Strings.dbg.json                                      
npm notice 748B   template/src/artifacts/@openzeppelin/contracts/utils/Strings.sol/Strings.json                                          
npm notice 11.2MB template/src/artifacts/build-info/f015013572fc56e71a92cc7a9fd14964.json                                                
npm notice 105B   template/src/artifacts/contracts/ERC20Token.sol/ERC20Token.dbg.json                                                    
npm notice 28.4kB template/src/artifacts/contracts/ERC20Token.sol/ERC20Token.json                                                        
npm notice 105B   template/src/artifacts/contracts/Greeter.sol/Greeter.dbg.json                                                          
npm notice 11.1kB template/src/artifacts/contracts/Greeter.sol/Greeter.json                                                              
npm notice 105B   template/src/artifacts/contracts/NFT.sol/NFT.dbg.json                                                                  
npm notice 91.6kB template/src/artifacts/contracts/NFT.sol/NFT.json                                                                      
npm notice 105B   template/src/artifacts/hardhat/console.sol/console.dbg.json                                                            
npm notice 726B   template/src/artifacts/hardhat/console.sol/console.json                                                                
npm notice 275B   template/styles/globals.css                                                                                            
npm notice 1.7kB  template/styles/Home.module.css                                                                                        
npm notice 619B   template/test/sample-test.js                                                                                           
npm notice === Tarball Details === 
npm notice name:          create-dao                              
npm notice version:       1.4.0                                   
npm notice filename:      create-dao-1.4.0.tgz                    
npm notice package size:  607.5 kB                                
npm notice unpacked size: 11.5 MB                                 
npm notice shasum:        44f1aa208f9663ef329e90aa87644ade23d984aa
npm notice integrity:     sha512-13+JwMQzUb35q[...]Xl41shg41EGzg==
npm notice total files:   74
Dhaiwat10 commented 2 years ago

Closing via #23

Had to add an .npmignore file and add the template folder to it