Developer-DAO / create-dao

MIT License
94 stars 15 forks source link

Support TypeScript #27

Open gaslimitreached opened 2 years ago

gaslimitreached commented 2 years ago

It is possible to support TypeScript:

Steps:

Reference for the steps above: create-next-app

revmischa commented 2 years ago

Why let people make non typescript projects at all? Nobody should be doing this in 2021 imo.

e-roy commented 2 years ago

correct, this is possible. I left code for the option of typescript install here https://github.com/Developer-DAO/create-dao/blob/0709815bf658dee5ae747c3591acea46003cb1e1/index.js#L20

and the code to copy the correct templated folder here https://github.com/Developer-DAO/create-dao/blob/0709815bf658dee5ae747c3591acea46003cb1e1/create-app.js#L138

I think the idea was to focus a working plain js version as a MVP and exploring ts later.

carlomigueldy commented 2 years ago

I would volunteer to help migrate this project to TypeScript

berteotti commented 2 years ago

Should we add TypeScript for a template project?

revmischa commented 2 years ago

I would volunteer to help migrate this project to TypeScript

Go for it! Give me typescript or give me death.

e-roy commented 2 years ago

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

carlomigueldy commented 2 years ago

Changes in the file structure coming down the pipeline. This helps for smoother npm publishing and future scaling of this project if tested and merged.

Linked PR

Nicely done, please ping me here in this issue whenever it's ready to be migrated to TypeScript and hopeful I'm not gonna interfere the development cycle