Developer-DAO / developer-dao-dot-com

The home for the Developer DAO website and CMS
https://www.developerdao.com/
MIT License
12 stars 16 forks source link

[Feature]: Season 1 Launch changes #5

Closed kempsterrrr closed 2 years ago

kempsterrrr commented 2 years ago

Context / Background / How This Idea Came To Fruition

To support the launch of Season 1 I'm proposing the following changes:

Problem / Opportunity

When launching a token, OpSec is a real concern and there are going to be people trying to scam folks in the community with fake mint sites, fake tokens and DM scams. We need to do whatever we can on the website to help protect against this.

Proposed Solution / How It Can Be Improved

See list above

Testing the changes

Manual

Additional Information

No response

kempsterrrr commented 2 years ago

For th first point I think we can probably use the existing marqeue banner, what do you think @mhmulford0 @andriishupta ?? Everything else seems pretty straight forward to me.

andriishupta commented 2 years ago

@kempsterrrr I have added the "news_ticker" field to the Home Query response so that we can pass this kind of information.

Currently, it consist from Statement{ title: string; description }[], but we can change it to be Link{ title, url, }[] and pass links to Claim site This Marquee header is located "above" Home page, so we can create a separate query for General/Settings to fetch on _app.tsx

For Footer same - we can add link to existing Component footer -> useful_links(Link[]) | discover(Link[]) | social(Link[])

andriishupta commented 2 years ago

short: answer -> yes, we can use existing Header and pass info from CMS + add required info to Footer

kempsterrrr commented 2 years ago

Great shout re the CMS @andriishupta - I wonder if we just get that field for the ticket to be a markdown block so we can put whatever text we want into the banner without having to worry about the data model?

andriishupta commented 2 years ago

yes it could be w/e we want

if that Marquee accepts Markdown correctly we can just create RichText field "content"

pseudo

query general {
  news_ticker {
    content // rich text
  }
}
kempsterrrr commented 2 years ago

Looks great to me mate. If you've got the time go for it otherwise I'll pick it up at the weekend :)

kempsterrrr commented 2 years ago

Just dropping a link to another issue in the CMS repo re markdown in the CMS - https://github.com/Developer-DAO/cms/issues/12

andriishupta commented 2 years ago

I would pick up CMS right away cause there shouldn't be many efforts, but with FE, we should check if we could easily just paste Markdown to Marque component

andriishupta commented 2 years ago

after merge of related CMS PR - we could query for { general } in _app.tsx to pass news_ticker to Marquee

kempsterrrr commented 2 years ago

remove underline from footer navlinks... add blog, school of code and p3rks

mulfdev commented 2 years ago

I have created this branch to sync all of the Season 1 todos. please use it as the base for any of those items. (also linked under development on the right side)

https://github.com/Developer-DAO/developer-dao-dot-com/tree/5-feature-season-1-launch-changes

kempsterrrr commented 2 years ago

Opened #15 to address these changes, see preview link in that PR for latest version.

andriishupta commented 2 years ago

@kempsterrrr, as a suggestion in chat or in GitHub issues, I mentioned that we could move the footer to General type

as I remember - we don't have a Header on the home page, but the heading / sub_heading - "Build web3 with friends."

suggestions:

our changes with "Moving Home Page to CMS" didn't introduce logic changes to FE code, so new can do it now

kempsterrrr commented 2 years ago

@andriishupta Apologies, by "Header" I'm referring to the global <Header /> component which includes the navigation.

If we're using the plugin given it can create multiple navigations imho it would be better to just create a both the Header navigation and footer navigation in there so they can be controlled via the cms. what do you think?

andriishupta commented 2 years ago

Yes, 100% we should do it, if navigation plugin would be suitable also for footer

andriishupta commented 2 years ago

now we can do more with ease when we have both projects at the same place and "unblocked" by using monorepo 🙇