Closed rasmuscnielsen closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/developdao/pixel-avatars/6CAmP6MMVFNXkcsiLU6CteK4oQbf
✅ Preview: https://pixel-avatars-git-feat-server-deployment-developdao.vercel.app
solves #82
So I just tweaked the implementation now to use environments. This makes it even more secure, as we can completely restrict any workflows to access the secrets unless it is triggered by a commit to their respective branch (staging + main) .
Furthermore we can restrict who can push to main. For now I have added a requirement for only PR that has at least 1 approval.
I have gone ahead and seeded the Production SERVER_PRIVATE_KEY.
I believe this can be the final public key used for launching the smart contract to production :-)
Thanks for your feedback @briangershon !
I believe needs: styling
is actually sufficient because the styling
in turn is set to needs: tests
. One could of course argue that this dependency is unnecessary, but in its current state I believe its working as expected.
I will try and merge the PR as is and then we can test & review what happens with the staging deployment and see if we want to tweak that 😊
This PR adds