search

Developer-DAO / pixel-avatars

A Polygon-based minting projects for Developer DAO members who own an Devs for Revolution NFT
https://pixel-devs.developerdao.com/
ISC License
133 stars 36 forks source link

Recommended contract changes #88

Closed briangershon closed 2 years ago

briangershon commented 2 years ago

Made recommended contract changes from @carlomigueldy's audit:

https://carlomigueldy.notion.site/Developer-DAO-Pixel-Avatars-Audit-6276c78909be4e939a25a21fb923268c

vercel[bot] commented 2 years ago

@briangershon is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

briangershon commented 2 years ago

Thanks @carlomigueldy for the code review! Fixed emits. Merging!

briangershon commented 2 years ago

Hey @rasmuscnielsen this contract has been updated and approved, but requires Vercel authorization to deploy. Please merge when you have a chance.

rasmuscnielsen commented 2 years ago

Hey @briangershon

Cool, looking great! I'll merge. Btw I think it'll actually be fine if you were to merge, it's just cause you're making a PR from your fork which will not deploy a preview of the the client 🙃

rasmuscnielsen commented 2 years ago

Ahhh I'm realising it's actually not vercel that's the issue but our main-branch protection requires at least one approval to merge 👌