Developer-DAO / pixel-avatars

A Polygon-based minting projects for Developer DAO members who own an Devs for Revolution NFT
https://pixel-devs.developerdao.com/
ISC License
133 stars 36 forks source link

Feat/share improvements #97

Closed rasmuscnielsen closed 2 years ago

rasmuscnielsen commented 2 years ago

I might need to tweak a few more things though as there are a few timing issues due slow CDN loads

vercel[bot] commented 2 years ago

@rasmuscnielsen is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

briangershon commented 2 years ago

Thanks for working on the spinners -- mainnet and ipfs are pretty slow -- I just minted mine and it only took a couple of minutes to "claim", but also seemed like forever awaiting my IPFS preview.

goldzulu commented 2 years ago

Abit if a worry coz we are definitely not loaded up yet

Sent from my iPhone

On 21 Feb 2022, at 02:32, Brian Gershon @.***> wrote:

 Thanks for working on the spinners -- mainnet and ipfs are pretty slow -- I just minted mine and it only took a couple of minutes to "claim", but also seemed like forever awaiting my IPFS preview.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

goldzulu commented 2 years ago

Could we do a placeholder that is greyed out or a dimmed version while waiting for the final ipfs version to load or can the server cache the IPFS call? And warm up the cache by programmatically calling the ipfs endpoints?

Sent from my iPhone

On 21 Feb 2022, at 02:32, Brian Gershon @.***> wrote:

 Thanks for working on the spinners -- mainnet and ipfs are pretty slow -- I just minted mine and it only took a couple of minutes to "claim", but also seemed like forever awaiting my IPFS preview.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

rasmuscnielsen commented 2 years ago

@goldzulu So in this PR I introduced using 2 IPFS CDN's and have them race each other for faster loads.

Further more I've now introduced a spinner + text. Additionally it is now pulling the actual PNG via ajax and injects it directly into the <img> so we can know exactly when the image is visible to the user and then fire off the confetti at that exact time.

Here is a video 🎉

https://user-images.githubusercontent.com/8465957/155005064-0ab28823-39c2-45e6-aaa2-dc7b709c8757.mov

In this case it loaded the image quite fast so the experience was good. I'll need to test it more to see if it behaves similar under all circumstances, but I believe we're good to merge this one now.

rasmuscnielsen commented 2 years ago

I'll go ahead and merge this one too