GitHub App authentication

DeveloperMetrics / deployment-frequency

A GitHub Action to roughly calculate DORA deployment frequency

MIT License

15 stars 8 forks source link

GitHub App authentication #12

Closed eBerdnA closed 1 year ago

eBerdnA commented 1 year ago

added parameters and functions for using GitHub App authentication. Partly addresses #7.

eBerdnA commented 1 year ago

@samsmithnz I guess we would also have to remove required for patToken and actionsToken. Right?

samsmithnz commented 1 year ago

@samsmithnz I guess we would also have to remove required for patToken and actionsToken. Right?

No - because they have defaults of "" - so even if they aren't used, a default of "" is passed in.

samsmithnz commented 1 year ago

I think it looks good overall - but we should add a GitHub app to the repo and some tests to the workflow file.!

eBerdnA commented 1 year ago

@samsmithnz I guess we would also have to remove required for patToken and actionsToken. Right?

No - because they have defaults of "" - so even if they aren't used, a default of "" is passed in.

But isn't required then redundant?

samsmithnz commented 1 year ago

Ahh. Yes. I see. Today I learned! Let's include the "" then. Required is redundant with a default - so we could remove that too!

samsmithnz commented 1 year ago

So I believe the last tasks left to close are to:

[x] Add to the readme.md the new parameters and an example of how to use them.
[ ] Update the workflow action to include a sample that uses the GitHub App. You can tell it's using a different auth, because the rate limit will be a different number.

eBerdnA commented 1 year ago

Just added the parameters and an example to the README.md.