search

DeveloperPaul123 / SimpleBluetoothLibrary

Android library for simplifying bluetooth usage.
Apache License 2.0
139 stars 34 forks source link

Initialize with flag to disable toast messages #20

Closed ritdaw closed 8 years ago

ritdaw commented 8 years ago

It would be great if all toast messages could be disabled with a flag when initialized, in certain scenarios we do not want to display messages such as "Device not available." and "Device connected!".

DeveloperPaul123 commented 8 years ago

Yeah I recently thought the same thing. I'll do that, and I think I'm going to switch to snackbars as well.

ritdaw commented 8 years ago

Great. If you were able to do a quick commit with a flag to disable them for now it would be much appreciated :)

DeveloperPaul123 commented 8 years ago

Ok I did a dirty commit. You can find it here: 'com.github.DeveloperPaul123:SimpleBluetoothLibrary:f20764725f'. I haven't tested this (haven't had time today) so if you could help me out that would be great. I think I'm going to draft a new release at this point and push off the BluetoothService feature. Keep the suggestions coming I want to make this library as great and comprehensive as possible.

DeveloperPaul123 commented 8 years ago

Commit f20764725f11a1091dd578fe4247b6aac7de224a closes #20

DeveloperPaul123 commented 8 years ago

Let me know if it works if you get a chance and I'll draft the v1.5 release.

ritdaw commented 8 years ago

Thanks, I'll try it this afternoon.

ritdaw commented 8 years ago

Works perfectly, tried without using setShouldShowSnackbars and they show and then used setShouldShowSnackbars(false) and they don't show as intended.

It might be worth doing a release without the service in the interim.

DeveloperPaul123 commented 8 years ago

Fantastic! And yes i'm going to save that for a future release along with allowing for multiple connections on a bluetoothserver connection. Thanks for all your help.