search

DeveloperPaul123 / thread-pool

A modern, fast, lightweight thread pool library based on C++20
https://DeveloperPaul123.github.io/thread-pool
MIT License
451 stars 34 forks source link

Update Minimum Required CMake Version #30

Closed DeveloperPaul123 closed 1 year ago

DeveloperPaul123 commented 1 year ago

Minimum required CMake version needs to be updated based on feedback below:

3.18.1, is this a problem? Do you think I just need to update? UPD: yep, you're right, updated to the latest 3.26.something and it ran. Thanks a lot for help (and great user experience right there, CMake!).

Originally posted by @VioletGiraffe in https://github.com/DeveloperPaul123/thread-pool/issues/25#issuecomment-1548275787

DeveloperPaul123 commented 1 year ago

Looks like the minimum required version may be 3.19 The original error was:

add_library INTERFACE library requires no source arguments.

And in CMake 3.19, that feature was added

New in version 3.19: An interface library target may be created with source files: https://cmake.org/cmake/help/latest/command/add_library.html