Im implementing shop system and library too for players

novasdream commented 9 years ago

Check my fork branch development.

Post your sugestions to my code style or something like..

( I need a feedback about licence and informations in header files ) https://github.com/novasdream/DevAAC

DSpeichert commented 9 years ago

You should raise a Pull Request to initiate discussion about your changes.

totolol123 commented 9 years ago

Looks good :+1:

novasdream commented 9 years ago

i that system is not ready to PullRequest.. It dont ready yet..

DSpeichert commented 9 years ago

Here are some brief comments then:

we don't want to alter database schema
"shops" is not the proper terminology for shop offers
adding "noty" (external library) is not appropriate unless absolutely necessary, angular libraries are preferred
you have made modifications (like changing of the page) that will prevent your PR from getting merged</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/novasdream"><img src="https://avatars.githubusercontent.com/u/3732117?v=4" />novasdream</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <blockquote> <p>we don't want to alter database schema</p> </blockquote> <p>Have any suggestions on how to get monsters data without accessing the XMLs all the time? (Cache will load a lot of data from disk can cause slowdowns) I think preloaded xmls think it's much occupied memory. Only way i found is put it in database.</p> <blockquote> <p>"shops" is not the proper terminology for shop offers</p> </blockquote> <p>You right.i will fix that.</p> <blockquote> <p>adding "noty" (external library) is not appropriate unless absolutely necessary, angular libraries are preferred</p> </blockquote> <p>hmm.. ok make sense... it is about enhancer in frontend only... </p> <p>I have some questions about StatusMessage usage... how to make it work in any page without change all html files from modules. and how i can send a StatusMessage.. ( dont have much samples ) </p> <blockquote> <p>you have made modifications (like changing of the page) that will prevent your PR from getting merged</p> </blockquote> <p>You right about that.. i will fix too.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/DSpeichert"><img src="https://avatars.githubusercontent.com/u/1254971?v=4" />DSpeichert</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>You can probably put that in APC (it's a soft dependency) or other cache. We should probably use laravel cache class. I might come up with something in future. In general, the database is definitely the worst place and parsing XML each time is also not a good idea as you said.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

DevelopersPL / DevAAC

Im implementing shop system and library too for players #25