Closed MadhavBahl closed 6 years ago
Have you installed NodeJS?
THere might be some error in mailer script i will check it out right away
Is the home page, i.e., localhost:8080/ working? Or, nothing at all is working?
@DDCreationStudios I am not able to make a new branch feature/addContactForm Can you please create one so that i can request pull in that branch
Hi @MadhavBahlMD! The setup works fine - I can start everything. I just can't send a mail. As the screenshot indicates there has to be a problem with login or the POST route ;)
But maybe let's wait for @robeerob and see if he can send it. :)
I will review my code. Will fix it before tomorrow :)
i found the error, it was a very small typo 😞 i named the same route as two different routes on client side and server side. will fix that ASAP
Done :) just add your own email id and password. at first it might show an error that google blocked sign in attemt, then go to your gmail account and review and unblock/authorize this, thereafter it will work perfect 👍
hi @MadhavBahlMD ! It works great! I let @robeerob review it and afterwards clean up the code and then merge. And reagrding the name of the branch: You can simply checkout a new branch with the feature name on your current branch and then open a new pull request. But it's not that important, I just wanted to remark that we have a naming convention. :)
@robeerob Works for me now. But I activated the option in our gmail account to let "insecure" apps login the account.
Thanks @DDCreationStudios :) I dont know why, but i am not able to create a new branch, please create a new branch and i will change the base from develop to feature/AddServer then 👍
@DDCreationStudios Apart from my review comments, works well for me locally!
Thanks for the complement @robeerob 😃 . The requested changes are being worked on 👍
@robeerob Can you update your review when everything is ok for you? Afterwards I will have a final look and merge :)
@DDCreationStudios LGTM :+1:
Hi @MadhavBahlMD! Thanks a lot for the Pull Request! Looks great, but it is not working. Changed password and also tried other usernames. Nothing is working. Has it worked on your machine? Checkout out the error I get:
Please also see our Readme to have a valid workflow here. Please
feature/addContactForm
or something similarThanks a lot for all your effort, we highly appreciate it! :)
@robeerob Any additional thoughts? Is it working on your machine?