DevelopingSpace / starchart

A self-serve tool for managing custom domains and certificates
MIT License
20 stars 13 forks source link

Don't list certificate challenge records for the end-user #332

Closed ghost closed 1 year ago

ghost commented 1 year ago

Exclude records from the user-facing record UI if type is TXT and subdomain is _acme-challenge

humphd commented 1 year ago

@Myrfion this is something you might want to do, since it's in the code you've been writing. If dnsRecord.subdomain === '_acme-challenge', skip showing it in the table.

humphd commented 1 year ago

Filed https://github.com/DevelopingSpace/starchart/issues/413 on dealing with these records in the user's limit.

Ririio commented 1 year ago

Did we already merge a PR for this issue?

humphd commented 1 year ago

Fixed by #424, which covered #413 and this at the same time.