search

DevelopingSpace / starchart

A self-serve tool for managing custom domains and certificates
MIT License
20 stars 13 forks source link

Remove isRenewable logic for DNS Records and always allow in UI #558

Closed humphd closed 1 year ago

humphd commented 1 year ago

We have UI code to check if a DNS Record isRenewable, which really never gets set to false. Let's always allow it.

The code was added in https://github.com/DevelopingSpace/starchart/pull/431, and we can just trim that out of the props, etc.

Ririio commented 1 year ago

We just need to have renewable to never be disabled right?

humphd commented 1 year ago

All the code for DNS Records that is calculating and passing around the isRenewable logic can get removed. We never need this button to be disabled.

One thing we could do that might be nice, though, is to show a toast() when we do the update, saying "DNS Record expiry updated" similar to how we do it for other parts of the app. Then the user knows something has happened.