search

DevelopingSpace / starchart

A self-serve tool for managing custom domains and certificates
MIT License
21 stars 13 forks source link

Improve Changelog when we create a release #654

Open humphd opened 1 year ago

humphd commented 1 year ago

We have some code in the release.yml workflow to create an automated release with changelog. However, the changelog is currently empty, and it would be nice to have it include the list of changes.

sfrunza13 commented 1 year ago

The way I thought this would work is that the action would determine the difference in commits between this and the last release commit but it seems as though it considers the current commit the last commit despite having all the commits in its payload

GitHub payload: {"after":"ee52c2653015d159f79185a242618bdd23104154","base_ref":null,"before":"61202bffc855d10a8a76ba4da5030866e979c39d","commits":[{"author":{"email":"50856799+SerpentBytes@users.noreply.github.com","name":"Taimoor D","username":"SerpentBytes"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"82ce095b904cafd3c84efc7c407892f4119082cb","message":"Restructure expiration notification worker code (#566)\n\n* Improve expiration notification code\r\n\r\n * Restructure expiration notification worker code\r\n * Make email message more clear\r\n * Add helpful comments\r\n * Remove extra dot\r\n * Fix typo in certification email subject\r\n * Update code to use status\r\n * Uncomment line\r\n * Update code based on feedback\r\n * Make message consistent\r\n * remove unnnecessary export keyword\r\n * update date locale\r\n * last update: make subject line more consistent\r\n * Update code based on feedback\r\n* remove if check","timestamp":"2023-04-14T16:37:52-04:00","tree_id":"90ae09089ee6117738950a953bafa6e3c7366a03","url":"https://github.com/DevelopingSpace/starchart/commit/82ce095b904cafd3c84efc7c407892f4119082cb"},{"author":{"email":"eakam1007@gmail.com","name":"Eakam","username":"Eakam1007"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"8bb55cedaad3d1e809f88aaaf7ca1a604517f14a","message":"Fix remix depreciation warnings (#614)\n\n* Update remix config to use flat routes\r\n\r\n* Convert routes to use v2 convention\r\n\r\n* Use auth as layout route name\r\n\r\n* Update formMethod for v2\r\n\r\n* Use v2 ErrorBoundry API\r\n\r\n* Use v2 meta function","timestamp":"2023-04-15T13:56:20-04:00","tree_id":"457b0a4eab8bbbc45689ba554e91285dc7e04107","url":"https://github.com/DevelopingSpace/starchart/commit/8bb55cedaad3d1e809f88aaaf7ca1a604517f14a"},{"author":{"email":"sfrunza@seneca.ca","name":"stefanaz2"},"committer":{"email":"77400826+sfrunza13@users.noreply.github.com","name":"sfrunza13","username":"sfrunza13"},"distinct":false,"id":"7ae743eaee93a8aeecd030d9942e728c5a25f2be","message":"no need for lights and camera, we got the action!","timestamp":"2023-04-15T22:47:09-04:00","tree_id":"159105cb19970e1d24d15d97767aeb945b1eb8a0","url":"https://github.com/DevelopingSpace/starchart/commit/7ae743eaee93a8aeecd030d9942e728c5a25f2be"},{"author":{"email":"50856799+SerpentBytes@users.noreply.github.com","name":"Taimoor D","username":"SerpentBytes"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"7a9428d9ebfded79fd9af07b3548a6c51b6b5ec6","message":"Replace DNSChecker with NSLookup (#624)","timestamp":"2023-04-16T10:05:45-04:00","tree_id":"2bd972f121c092655978d226610e0b8fe0627587","url":"https://github.com/DevelopingSpace/starchart/commit/7a9428d9ebfded79fd9af07b3548a6c51b6b5ec6"},{"author":{"email":"eakam1007@gmail.com","name":"Eakam","username":"Eakam1007"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"f30b3d26b7cd0c1097c6bf328b4a1bd1008a3035","message":"Improve DNS Records table responsiveness on mobile (#619)\n\n* Hide some columns below small viewports\r\n\r\n* Show smaller new DNS Record button on smaller screens\r\n\r\n* Group DNS Record info together\r\n\r\n* Move all buttons to below DNS Record info [skip ci]\r\n\r\n* Add margins and make buttons take entire row","timestamp":"2023-04-16T11:31:02-04:00","tree_id":"e1288a4a1915b8bf3228c70286843aea165bc5d1","url":"https://github.com/DevelopingSpace/starchart/commit/f30b3d26b7cd0c1097c6bf328b4a1bd1008a3035"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"d4e8d1c58a3d8a919d36cd7038d794397530e08a","message":"1.0.0-alpha","timestamp":"2023-04-16T16:30:51-04:00","tree_id":"8294053474835cf6e4ec5bc3b437c540181de121","url":"https://github.com/DevelopingSpace/starchart/commit/d4e8d1c58a3d8a919d36cd7038d794397530e08a"},{"author":{"email":"xRiriio@gmail.com","name":"Ririio","username":"Ririio"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"b11d473b947b33eaf9c70684f0953c8f1222c0a4","message":"making username and avatar clickable","timestamp":"2023-04-17T08:32:03-04:00","tree_id":"7b5cc5fde61ee87dcc263a1178b7c84aff8d962f","url":"https://github.com/DevelopingSpace/starchart/commit/b11d473b947b33eaf9c70684f0953c8f1222c0a4"},{"author":{"email":"83015577+cychu42@users.noreply.github.com","name":"Chen-Yuan Chu","username":"cychu42"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"13f9b6200352f75a872054e0e30a0240eecb9434","message":"Setup database migration for staging and prod (#601)\n\n* Setup database migration for staging and prod\r\n* Add migration in docker-entrypoint.sh, when DATABASE_SETUP !=1\r\n* Add migration file creation script, with required permission\r\n* Create initial migration file\r\n* Add documentation for making migration files\r\n* Adjust database setup with the right command\r\n* Adjust docker deployment for update\r\n* Change database setup process name\r\n* Add comments to database_migration and DANGER_DATABASE_WIPE_REINITIALIZE\r\n* Add warning about schema change without Prisma","timestamp":"2023-04-17T10:52:53-04:00","tree_id":"a710e420eade2d56e7d437b167cdc339b725ff34","url":"https://github.com/DevelopingSpace/starchart/commit/13f9b6200352f75a872054e0e30a0240eecb9434"},{"author":{"email":"cchu42@myseneca.ca","name":"cchu42","username":"cychu42"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"f0a29fb4c45204b754c23eae800b4f9b341bf18e","message":"Remove deactivate","timestamp":"2023-04-17T11:53:27-04:00","tree_id":"614c483b5ee783e156f3d636afea8f919e1e3c54","url":"https://github.com/DevelopingSpace/starchart/commit/f0a29fb4c45204b754c23eae800b4f9b341bf18e"},{"author":{"email":"cchu42@myseneca.ca","name":"cchu42","username":"cychu42"},"committer":{"email":"83015577+cychu42@users.noreply.github.com","name":"Chen-Yuan Chu","username":"cychu42"},"distinct":false,"id":"92653f93a7feb217b129dcdd48d16d51c5bea306","message":"Revemo Development heading from README.md","timestamp":"2023-04-17T13:52:27-04:00","tree_id":"7553ee45ebcfc27cc18420532bfaf9b52cb7272f","url":"https://github.com/DevelopingSpace/starchart/commit/92653f93a7feb217b129dcdd48d16d51c5bea306"},{"author":{"email":"59734889+Genne23v@users.noreply.github.com","name":"Wonkeun No","username":"Genne23v"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"e68732224e5c052fb69d3c354a8803a7148b16e3","message":"Update certificate UI test (#613)","timestamp":"2023-04-17T20:32:25-04:00","tree_id":"7778596d4acf1a52fa5a216d0e429223629ae87a","url":"https://github.com/DevelopingSpace/starchart/commit/e68732224e5c052fb69d3c354a8803a7148b16e3"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"29f5830347f0f6626bee408f8d741b0c34c729ae","message":"Rework default tags for staging and production builds","timestamp":"2023-04-18T17:09:58-04:00","tree_id":"a5e13418153bc28dfe87eff6b7adfad5b59e650c","url":"https://github.com/DevelopingSpace/starchart/commit/29f5830347f0f6626bee408f8d741b0c34c729ae"},{"author":{"email":"32577022+Ririio@users.noreply.github.com","name":"Ririio","username":"Ririio"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"96c2f445cdf6245f423643443c1c1444eb1647be","message":"Add \"Alt\" Text Attribute to Image (#627)\n\n* making username and avatar clickable\r\n\r\nadding alt for instance of image\r\n\r\nremoving changes from header\r\n\r\nreverting changes of header to original\r\n\r\nrename DisplayPage -> DisplayMessagePage\r\n\r\nalt should describe image\r\n\r\n* DisplayMessage -> ImageWithDisplay","timestamp":"2023-04-18T17:34:24-04:00","tree_id":"991a40a31bd59374278036d7b84f752910d3c983","url":"https://github.com/DevelopingSpace/starchart/commit/96c2f445cdf6245f423643443c1c1444eb1647be"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"0b04beb794b7ed970c6e24009ec37d276e25c44e","message":"Update deps for 1.0.0","timestamp":"2023-04-18T19:29:14-04:00","tree_id":"98cfbaa6cd07935d44725babb55a1251d1363107","url":"https://github.com/DevelopingSpace/starchart/commit/0b04beb794b7ed970c6e24009ec37d276e25c44e"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"cccd670386f2439cef4ec6442d65186b23190d47","message":"Reduce number of browsers we run in e2e tests","timestamp":"2023-04-18T19:31:11-04:00","tree_id":"52518977f74f13c29494a69f3ff594fe33b1cb2a","url":"https://github.com/DevelopingSpace/starchart/commit/cccd670386f2439cef4ec6442d65186b23190d47"},{"author":{"email":"50856799+SerpentBytes@users.noreply.github.com","name":"Taimoor D","username":"SerpentBytes"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":false,"id":"9c3a6c6421d12b75b5267207773112aac806af05","message":"use unique job id in notifications worker (#640)\n\n* * fix: certification expiration resulting in multiple emails\r\n* fix 2\r\n* fix 3\r\n* Use unique Job Id in notifications worker\r\n* fixes 5\r\n\r\n* fix: use jobId\r\n\r\n* add jobId within french braces","timestamp":"2023-04-18T19:57:55-04:00","tree_id":"eb694aeaebe1fdafb0c8d87111883b0359496e03","url":"https://github.com/DevelopingSpace/starchart/commit/9c3a6c6421d12b75b5267207773112aac806af05"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"3c078cf08e8156a7559a3ed381f5a7a9513d3a67","message":"Log when impersonation starts/stops","timestamp":"2023-04-19T08:30:36-04:00","tree_id":"7b62140cdae80504dc4d4457e03f42540439ddb1","url":"https://github.com/DevelopingSpace/starchart/commit/3c078cf08e8156a7559a3ed381f5a7a9513d3a67"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"382db7fb9ed38dc5596ca30e44ea8b17da507271","message":"Don't join chain elements with \\r\\n","timestamp":"2023-04-19T12:47:41-04:00","tree_id":"b02a62c76e6cca0f0f3d71dafbbd9249b386b963","url":"https://github.com/DevelopingSpace/starchart/commit/382db7fb9ed38dc5596ca30e44ea8b17da507271"},{"author":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"committer":{"email":"david.andrew.humphrey@gmail.com","name":"David Humphrey","username":"humphd"},"distinct":false,"id":"8392bb9931553db5597f618524d2e8dc061a6fff","message":"1.0.0","timestamp":"2023-04-19T12:59:18-04:00","tree_id":"9295e9352ab62f57db34dd0c91bbafbc3773bfff","url":"https://github.com/DevelopingSpace/starchart/commit/8392bb9931553db5597f618524d2e8dc061a6fff"},{"author":{"email":"77400826+sfrunza13@users.noreply.github.com","name":"sfrunza13","username":"sfrunza13"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":true,"id":"ee52c2653015d159f79185a242618bdd23104154","message":"Merge pull request #647 from DevelopingSpace/main\n\nThe Official 1.0.0 release","timestamp":"2023-04-19T13:11:51-04:00","tree_id":"9295e9352ab62f57db34dd0c91bbafbc3773bfff","url":"https://github.com/DevelopingSpace/starchart/commit/ee52c2653015d159f79185a242618bdd23104154"}],"compare":"https://github.com/DevelopingSpace/starchart/compare/61202bffc855...ee52c2653015","created":false,"deleted":false,"forced":false,"head_commit":{"author":{"email":"77400826+sfrunza13@users.noreply.github.com","name":"sfrunza13","username":"sfrunza13"},"committer":{"email":"noreply@github.com","name":"GitHub","username":"web-flow"},"distinct":true,"id":"ee52c2653015d159f79185a242618bdd23104154","message":"Merge pull request #647 from DevelopingSpace/main\n\nThe Official 1.0.0 release","timestamp":"2023-04-19T13:11:51-04:00","tree_id":"9295e9352ab62f57db34dd0c91bbafbc3773bfff","url":"https://github.com/DevelopingSpace/starchart/commit/ee52c2653015d159f79185a242618bdd23104154"},"organization":{"avatar_url":"https://avatars.githubusercontent.com/u/124643295?v=4","description":"","events_url":"https://api.github.com/orgs/DevelopingSpace/events","hooks_url":"https://api.github.com/orgs/DevelopingSpace/hooks","id":124643295,"issues_url":"https://api.github.com/orgs/DevelopingSpace/issues","login":"DevelopingSpace","members_url":"[https://api.github.com/orgs/DevelopingSpace/members{/member}](https://api.github.com/orgs/DevelopingSpace/members%7B/member%7D)","node_id":"O_kgDOB23n3w","public_members_url":"[https://api.github.com/orgs/DevelopingSpace/public_members{/member}](https://api.github.com/orgs/DevelopingSpace/public_members%7B/member%7D)","repos_url":"https://api.github.com/orgs/DevelopingSpace/repos","url":"https://api.github.com/orgs/DevelopingSpace"},"pusher":{"email":"77400826+sfrunza13@users.noreply.github.com","name":"sfrunza13"},"ref":"refs/heads/release","repository":{"allow_forking":true,"archive_url":"[https://api.github.com/repos/DevelopingSpace/starchart/{archive_format}{/ref}](https://api.github.com/repos/DevelopingSpace/starchart/%7Barchive_format%7D%7B/ref%7D)","archived":false,"assignees_url":"[https://api.github.com/repos/DevelopingSpace/starchart/assignees{/user}](https://api.github.com/repos/DevelopingSpace/starchart/assignees%7B/user%7D)","blobs_url":"[https://api.github.com/repos/DevelopingSpace/starchart/git/blobs{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/git/blobs%7B/sha%7D)","branches_url":"[https://api.github.com/repos/DevelopingSpace/starchart/branches{/branch}](https://api.github.com/repos/DevelopingSpace/starchart/branches%7B/branch%7D)","clone_url":"https://github.com/DevelopingSpace/starchart.git","collaborators_url":"[https://api.github.com/repos/DevelopingSpace/starchart/collaborators{/collaborator}](https://api.github.com/repos/DevelopingSpace/starchart/collaborators%7B/collaborator%7D)","comments_url":"[https://api.github.com/repos/DevelopingSpace/starchart/comments{/number}](https://api.github.com/repos/DevelopingSpace/starchart/comments%7B/number%7D)","commits_url":"[https://api.github.com/repos/DevelopingSpace/starchart/commits{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/commits%7B/sha%7D)","compare_url":"[https://api.github.com/repos/DevelopingSpace/starchart/compare/{base}...{head}](https://api.github.com/repos/DevelopingSpace/starchart/compare/%7Bbase%7D...%7Bhead%7D)","contents_url":"[https://api.github.com/repos/DevelopingSpace/starchart/contents/{+path}](https://api.github.com/repos/DevelopingSpace/starchart/contents/%7B+path%7D)","contributors_url":"https://api.github.com/repos/DevelopingSpace/starchart/contributors","created_at":1669140945,"default_branch":"main","deployments_url":"https://api.github.com/repos/DevelopingSpace/starchart/deployments","description":"A self-serve tool for managing custom domains and certificates","disabled":false,"downloads_url":"https://api.github.com/repos/DevelopingSpace/starchart/downloads","events_url":"https://api.github.com/repos/DevelopingSpace/starchart/events","fork":false,"forks":16,"forks_count":16,"forks_url":"https://api.github.com/repos/DevelopingSpace/starchart/forks","full_name":"DevelopingSpace/starchart","git_commits_url":"[https://api.github.com/repos/DevelopingSpace/starchart/git/commits{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/git/commits%7B/sha%7D)","git_refs_url":"[https://api.github.com/repos/DevelopingSpace/starchart/git/refs{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/git/refs%7B/sha%7D)","git_tags_url":"[https://api.github.com/repos/DevelopingSpace/starchart/git/tags{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/git/tags%7B/sha%7D)","git_url":"git://github.com/DevelopingSpace/starchart.git","has_discussions":true,"has_downloads":true,"has_issues":true,"has_pages":false,"has_projects":true,"has_wiki":true,"homepage":null,"hooks_url":"https://api.github.com/repos/DevelopingSpace/starchart/hooks","html_url":"https://github.com/DevelopingSpace/starchart","id":569393314,"is_template":false,"issue_comment_url":"[https://api.github.com/repos/DevelopingSpace/starchart/issues/comments{/number}](https://api.github.com/repos/DevelopingSpace/starchart/issues/comments%7B/number%7D)","issue_events_url":"[https://api.github.com/repos/DevelopingSpace/starchart/issues/events{/number}](https://api.github.com/repos/DevelopingSpace/starchart/issues/events%7B/number%7D)","issues_url":"[https://api.github.com/repos/DevelopingSpace/starchart/issues{/number}](https://api.github.com/repos/DevelopingSpace/starchart/issues%7B/number%7D)","keys_url":"[https://api.github.com/repos/DevelopingSpace/starchart/keys{/key_id}](https://api.github.com/repos/DevelopingSpace/starchart/keys%7B/key_id%7D)","labels_url":"[https://api.github.com/repos/DevelopingSpace/starchart/labels{/name}](https://api.github.com/repos/DevelopingSpace/starchart/labels%7B/name%7D)","language":"TypeScript","languages_url":"https://api.github.com/repos/DevelopingSpace/starchart/languages","license":{"key":"mit","name":"MIT License","node_id":"MDc6TGljZW5zZTEz","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"master_branch":"main","merges_url":"https://api.github.com/repos/DevelopingSpace/starchart/merges","milestones_url":"[https://api.github.com/repos/DevelopingSpace/starchart/milestones{/number}](https://api.github.com/repos/DevelopingSpace/starchart/milestones%7B/number%7D)","mirror_url":null,"name":"starchart","node_id":"R_kgDOIfBAog","notifications_url":"[https://api.github.com/repos/DevelopingSpace/starchart/notifications{?since](https://api.github.com/repos/DevelopingSpace/starchart/notifications%7B?since),all,participating}","open_issues":13,"open_issues_count":13,"organization":"DevelopingSpace","owner":{"avatar_url":"https://avatars.githubusercontent.com/u/124643295?v=4","email":null,"events_url":"[https://api.github.com/users/DevelopingSpace/events{/privacy}](https://api.github.com/users/DevelopingSpace/events%7B/privacy%7D)","followers_url":"https://api.github.com/users/DevelopingSpace/followers","following_url":"[https://api.github.com/users/DevelopingSpace/following{/other_user}](https://api.github.com/users/DevelopingSpace/following%7B/other_user%7D)","gists_url":"[https://api.github.com/users/DevelopingSpace/gists{/gist_id}](https://api.github.com/users/DevelopingSpace/gists%7B/gist_id%7D)","gravatar_id":"","html_url":"https://github.com/DevelopingSpace","id":124643295,"login":"DevelopingSpace","name":"DevelopingSpace","node_id":"O_kgDOB23n3w","organizations_url":"https://api.github.com/users/DevelopingSpace/orgs","received_events_url":"https://api.github.com/users/DevelopingSpace/received_events","repos_url":"https://api.github.com/users/DevelopingSpace/repos","site_admin":false,"starred_url":"[https://api.github.com/users/DevelopingSpace/starred{/owner}{/repo}](https://api.github.com/users/DevelopingSpace/starred%7B/owner%7D%7B/repo%7D)","subscriptions_url":"https://api.github.com/users/DevelopingSpace/subscriptions","type":"Organization","url":"https://api.github.com/users/DevelopingSpace"},"private":false,"pulls_url":"[https://api.github.com/repos/DevelopingSpace/starchart/pulls{/number}](https://api.github.com/repos/DevelopingSpace/starchart/pulls%7B/number%7D)","pushed_at":1681924311,"releases_url":"[https://api.github.com/repos/DevelopingSpace/starchart/releases{/id}](https://api.github.com/repos/DevelopingSpace/starchart/releases%7B/id%7D)","size":11429,"ssh_url":"git@github.com:DevelopingSpace/starchart.git","stargazers":15,"stargazers_count":15,"stargazers_url":"https://api.github.com/repos/DevelopingSpace/starchart/stargazers","statuses_url":"[https://api.github.com/repos/DevelopingSpace/starchart/statuses/{sha}](https://api.github.com/repos/DevelopingSpace/starchart/statuses/%7Bsha%7D)","subscribers_url":"https://api.github.com/repos/DevelopingSpace/starchart/subscribers","subscription_url":"https://api.github.com/repos/DevelopingSpace/starchart/subscription","svn_url":"https://github.com/DevelopingSpace/starchart","tags_url":"https://api.github.com/repos/DevelopingSpace/starchart/tags","teams_url":"https://api.github.com/repos/DevelopingSpace/starchart/teams","topics":[],"trees_url":"[https://api.github.com/repos/DevelopingSpace/starchart/git/trees{/sha}](https://api.github.com/repos/DevelopingSpace/starchart/git/trees%7B/sha%7D)","updated_at":"2023-04-09T14:40:15Z","url":"https://github.com/DevelopingSpace/starchart","visibility":"public","watchers":15,"watchers_count":15,"web_commit_signoff_required":false},"sender":{"avatar_url":"https://avatars.githubusercontent.com/u/77400826?v=4","events_url":"[https://api.github.com/users/sfrunza13/events{/privacy}](https://api.github.com/users/sfrunza13/events%7B/privacy%7D)","followers_url":"https://api.github.com/users/sfrunza13/followers","following_url":"[https://api.github.com/users/sfrunza13/following{/other_user}](https://api.github.com/users/sfrunza13/following%7B/other_user%7D)","gists_url":"[https://api.github.com/users/sfrunza13/gists{/gist_id}](https://api.github.com/users/sfrunza13/gists%7B/gist_id%7D)","gravatar_id":"","html_url":"https://github.com/sfrunza13","id":77400826,"login":"sfrunza13","node_id":"MDQ6VXNlcjc3NDAwODI2","organizations_url":"https://api.github.com/users/sfrunza13/orgs","received_events_url":"https://api.github.com/users/sfrunza13/received_events","repos_url":"https://api.github.com/users/sfrunza13/repos","site_admin":false,"starred_url":"[https://api.github.com/users/sfrunza13/starred{/owner}{/repo}](https://api.github.com/users/sfrunza13/starred%7B/owner%7D%7B/repo%7D)","subscriptions_url":"https://api.github.com/users/sfrunza13/subscriptions","type":"User","url":"https://api.github.com/users/sfrunza13"}}

The "difference" between current release and previous release is apparently 0 commits.

The only exception was the first run of this release flow which took the difference from head to current commit and actually correctly found the difference in commits and created a changelog with the actual commits within it. (Because there was no existing release tag to compare with at the time)

Not sure yet why it is this way. My best guess is that the release tag is being set to the latest commit before the comparison occurs and that is why it deems there shouldn't be any commits displayed but this was not the advertised behavior: https://github.com/marvinpinto/action-automatic-releases

sfrunza13 commented 1 year ago

Perhaps I should name the tag something other than the branches name...

humphd commented 1 year ago

Or swap to a different action for this task, there are tons of "changelog" actions out there. Another one might do a better job using our branch-based release flow.

sfrunza13 commented 1 year ago

Just tested it on my own repo, I think I was right about just switching the tag from release. I had the same problem then changed it to latest and this is the ensuing result (after the original commit after the switch which released from the last head to the new latest tag so this one is from previous latest to current) image

Determining state of the previous release
  Searching for SHA corresponding to previous "tags/latest" release tag
  Retrieving commits between latest and 43423271d8bc30a54da53cf2[15](https://github.com/sfrunza13/testingReleases/actions/runs/4758224306/jobs/8455996752#step:2:18)9ac344bab01a1f
  Successfully retrieved 4 commits between latest and 43423271d8bc30a54da53cf2159ac344bab01a1f
humphd commented 1 year ago

This wasn't enough: https://github.com/DevelopingSpace/starchart/releases/tag/latest

Re-opening.

sfrunza13 commented 1 year ago

I am really not sure why this is happening since I wrote the actions the same but the result differs in the following:

Generating changelog
  Found 1 pull request(s) associated with commit 5862e0a4e92b48a7b9c1d570edb524598e51c403
  Found 1 pull request(s) associated with commit c[18](https://github.com/DevelopingSpace/starchart/actions/runs/4773322713/jobs/8486323972#step:2:22)efda7df602f13b0b74e3af6c56ac1c0792e68
  Found 1 pull request(s) associated with commit 61202bffc855d10a8a76ba4da5030866e979c39d
  Found 1 pull request(s) associated with commit ee52c2653015d159f79185a242618bdd23104154
  Found 1 pull request(s) associated with commit 0516f72efd8243edb6eee09c93c5a2526c9984b6
  Found 1 pull request(s) associated with commit 013a6a943f25a8408c4ba33bbf78f7b58c95289e
  Found 1 pull request(s) associated with commit 1daa982cc80a5d8ba5[19](https://github.com/DevelopingSpace/starchart/actions/runs/4773322713/jobs/8486323972#step:2:23)4c49fc80747d0e6f4546
    Generating changelog
  Found 1 pull request(s) associated with commit 4393754de378be588ca8ff7[20](https://github.com/sfrunza13/testingReleases/actions/runs/4758356052/jobs/8456309764#step:2:24)e6c11de4b8fb436
  Adding commit "trying to format the releases" to the changelog
  Found 1 pull request(s) associated with commit 35f3af920dd9dbbb8bae0a1694c4f37991dc46a1
  Adding commit "turned it into a node project" to the changelog
  Found 1 pull request(s) associated with commit f029a6de1167612c4cec36fc5bb3207c3d7[22](https://github.com/sfrunza13/testingReleases/actions/runs/4758356052/jobs/8456309764#step:2:26)889
  Adding commit "after node project" to the changelog

It seems to find the pull requests now but does not successfully add the commits.

Seems to have problems in the following method, I'm unsure why still. https://github.dev/marvinpinto/actions/blob/9ecff5f61cbff8b2d81c3a064cb805931e730fdd/packages/automatic-releases/src/main.ts#L179

humphd commented 1 year ago

I don't think we should spend too much time on this Action, since there are lots of others we could use. If this won't do what we want, let's use another.

sfrunza13 commented 1 year ago

If we use the following https://github.com/ardalanamini/auto-changelog we can create changelogs that look like the following:

image

but the problem would be that the commit messages require a prefix or else they will not show up.

To be categorized under the changelog they would need to be one of the types defined by us in the .yml file here:

commit-types: |
            breaking: Breaking Changes
            feat: New Features
            fix: Bug Fixes
            revert: Reverts
            perf: Performance Improvements
            refactor: Refactors
            deps: Dependencies
            docs: Documentation Changes
            style: Code Style Changes
            build: Build System
            ci: Continuous Integration
            test: Tests
            chore: Chores
            other: Other Changes
humphd commented 1 year ago

Special commit messages won't work with student developers, in my experience.