search

DevelopmentCool2449 / colorful-mode

🎨Preview any color in your buffer
GNU General Public License v3.0
58 stars 5 forks source link

Thanks and idea: add help-mode to default global modes #13

Open Martinsos opened 1 week ago

Martinsos commented 1 week ago

Thanks for this package! It helped me when I got into situation where rainbow-mode was messing up Help buffers -> it messed up their faces, specifically headers, but also elisp code coloring. Took me some time to figure out it was caused by rainbow-mode.

However, colorful-mode has no issues with it though, all works fine!

I also wanted to suggest to maybe add help-mode to default global modes -> It is super useful to be able to see the colors when you open Help buffer for a face, with describe-face. From what I saw, it causes no conflicts and works fine in help-mode.

image

Additional question: Why, in global-colorful-modes, do you list all those modes, and then also prog-mode? If this is being used to add hooks to turn on the colorful-mode for those modes, then isn't it enough just to list prog-mode, since all the rest of the modes you have there currently use prog-mode as the base mode? Ok, maybe not for latex-mode, I would guess that one does not extend prog-mode. It would make sense to add help-mode though, as that one doesn't have prod-mode as base mode, in case you do end up adding it. I might have gotten somethign wrong here though, I am no emacs expert.

jcs090218 commented 4 days ago

Thanks for opening this issue!

I agree with you. Adding help-mode can be very useful. 😁

FYI, I didn't write the original code, but I am the maintainer of this package. :)