DevelopmentCool2449 / colorful-mode

🎨Preview any color in your buffer
GNU General Public License v3.0
55 stars 3 forks source link

enable colorful-mode in specified modes #5

Closed seagle0128 closed 2 months ago

seagle0128 commented 2 months ago

https://github.com/DevelopmentCool2449/colorful-mode/blob/cc94056fea3457f6e40c0c4ac8b9569de9c1f47e/colorful-mode.el#L769-L771

IMO, it's better make the predicate modes customizable in global-colorful-mode.

DevelopmentCool2449 commented 2 months ago

As far as i know it's already customizable, you can check global-colorful-modes option.

seagle0128 commented 2 months ago

I didn't see the global-colorful-modes option in the codes. Just this

;; Silence a byte-compile warning about global-colorful-modes not
;; being defined, if anyone knows why this happens please send a
;; patch.
(defvar global-colorful-modes)
DevelopmentCool2449 commented 2 months ago

global-colorful-modes is automatically defined by macro define-globalized-minor-mode

   (unless colorful-mode
     (colorful-mode t)))

 ;;;###autoload
 (define-globalized-minor-mode global-colorful-mode
   colorful-mode turn-on-colorful-mode
   :predicate '(mhtml-mode html-ts-mode latex-mode prog-mode))
seagle0128 commented 2 months ago

Okay, then I am closing it.