search

DevelopmentalImagingMCRI / MCRIBS

Surface version of the M-CRIB atlases.
13 stars 7 forks source link

Found a misnaming of intermediate file in MCRIBTissueSegMCRIBS #16

Open joey-scanga opened 1 day ago

joey-scanga commented 1 day ago

Not sure if you'd prefer I make a pull request, or if you'd like to add this fix in yourself, but I noticed on line 364, the output path of an intermediate antsApplyTransforms command is:

--output ${OUTPUTPREFIX}_majority_dkt_affine_reg.nii.gz

Later, on line 421, what I believe is referring to this output file uses the substring "dkt_majority_affine_reg" in the file name instead of "majority_dkt_affine_reg":

mri_binarize --i ${OUTPUTPREFIX}_dkt_majority_affine_reg.nii.gz --o ${OUTPUTPREFIX}_dkt_majority_affine_reg_fissure.nii.gz --match 1005 2005 1013 2013 --dilate 5 --noverbose

This has been causing me errors in my environment, and I'm not sure of the extent to which subsequent errors can cascade from this step here

joey-scanga commented 1 day ago

Happy to make a pull request to fix this if you'd like!