Developmint / nuxt-purgecss

Drop superfluous CSS! A neat PurgeCSS wrapper for Nuxt.js
MIT License
479 stars 19 forks source link

chore: updated nuxt version to stable 2 #6

Closed bovas85 closed 6 years ago

bovas85 commented 6 years ago

removed $GIT_PARAMS as not recognised (-e defaults to commit message) added missing --detectOpenHandles to jest to stop async processes.

manniL commented 6 years ago

Hey @bovas85! :wave:

Thanks for the PR. Any reason you want to use Nuxt 2 instead of the bleeding edge build for testing? I think an advantage would be to recognize early issues with (unreleased) edge builds, that's the reason I used it there.

bovas85 commented 6 years ago

Hey @manniL , I think a nuxt-edge would be more suitable for a dev branch rather than release. I'm using this for a prod site (although it's my choice to) and it'd be more in sync with a stable version.

manniL commented 6 years ago

@bovas85 Ah, I see your point there. But there won't be changes that break the stable nuxt release (as nuxt-edge shouldn't introduce breaking changes and if, I'd add a way to support both versions, current + future). :relaxed:

bovas85 commented 6 years ago

I understand, that's a fair point. I can close this then (although I'd still make the commitlint change in a separate PR as that's blocking potentially others from contributing?)

manniL commented 6 years ago

I'm looking forward to include the changes through separate PRs :+1:

Also, please use yarn 1.10 or higher to avoid unsetting the integration field (if possible, otherwise I can fix that too)

bovas85 commented 6 years ago

I have yarn 1.9.4, where do you see that change?

manniL commented 6 years ago

Look in the Files changed menu of your PR :relaxed:

image

bovas85 commented 6 years ago

I think that was due to removing edge and then adding nuxt 2