Developmint / nuxt-purgecss

Drop superfluous CSS! A neat PurgeCSS wrapper for Nuxt.js
MIT License
478 stars 18 forks source link

Should it be in buildModules and devDependency? #62

Closed rchl closed 4 years ago

rchl commented 4 years ago

Shouldn't documentation state that it should be added in buildModules (or devModules) rather than modules? And shouldn't it state that this is devDependency then? As far as I can see it only affects building.

manniL commented 4 years ago

It depends on how you handle devDeps and deps :relaxed:

Using it in buildModules instead of modules should be documented, sure. I'd accept a PR there :relaxed:

simllll commented 4 years ago

We have it inside of buildModules and all works fine ;) (and therefore also listed as dev deps)

rchl commented 4 years ago

I'm not sure what you meant by this @manniL

It depends on how you handle devDeps and deps

manniL commented 4 years ago

@rchl

Some people use devDeps only for linters + testing utils and put "the rest" (so deps needed at build and at run time) in deps.

Others use devDeps for everything build-related and deps only for runtime builds.

simplenotezy commented 4 years ago

Would like to know how it can be used in devModules instead 😊 Currently added it to "modules", but not sure what the gains are of adding it to devModules

curtisbelt commented 4 years ago

@simplenotezy hey there, devModules is actually deprecated in favor of buildModules, and you can indeed add it there. The benefit is that buildModules are are not loaded in nuxt start.

simplenotezy commented 4 years ago

Thanks!

manniL commented 4 years ago

Will add that in the README. Thanks @rchl