search

Developmint / nuxt-svg-loader

SVGs as components, also on the server side!
MIT License
144 stars 14 forks source link

Feature: accept module options #38

Open koresar opened 5 years ago

koresar commented 5 years ago

This doesn't work

modules: [
    ["nuxt-svg-loader", { svgoConfig: false }]
],

But this works:

modules: [ "nuxt-svg-loader" ],
svgLoader: { svgoConfig: false },

Bug or by design?

manniL commented 5 years ago

Bug or by design?

By lazyness :joy:

Accepting a PR (+tests) that takes the moduleOptions too and does correct merging if necessary. :relaxed:

Shouldn't be a huge thing

koresar commented 5 years ago

I went another way. The svg-to-vue-component module now has Nuxt support out of the box.

But thank you anyway for the prompt reply.

manniL commented 5 years ago

Keeping it open anyway :relieved: