search

Developmint / nuxt-svg-loader

SVGs as components, also on the server side!
MIT License
144 stars 14 forks source link

Adding additional info about a lib usage #8

Closed AndrewBogdanovTSS closed 6 years ago

AndrewBogdanovTSS commented 6 years ago

fixes https://github.com/Developmint/nuxt-svg-loader/issues/7

manniL commented 6 years ago

@AndrewBogdanovTSS Thanks a lot!

One small question: Why would you add it as devDependency and not as dependency?

I'll usually add everything as dependency that's needed to rebuild my stuff on my server. (If you are just want to start it there, I see the point only adding nuxt-start and other critical deps there)

AndrewBogdanovTSS commented 6 years ago

@manniL I was just following the recommendation of vue-svg-loader. They add it as a dev dependency.

manniL commented 6 years ago

This totally makes sense for a Vue application. I'd go with adding it to the dependencies though to stay in line with the other Nuxt modules (eg. axios, auth-module, ...)

manniL commented 6 years ago

Thank you for your contribution ☺️