search

DeviationTX / deviation

Custom firmware for RC Transmitters
http://www.deviationtx.com
GNU General Public License v3.0
247 stars 153 forks source link

Fix bind problem for FrSky XM+ v2.1.2 firmware #1011

Closed MJ666 closed 3 years ago

MJ666 commented 3 years ago

Based on an update of the MPM code. All thanks go to Pascal for doing the fix.

https://github.com/pascallanger/DIY-Multiprotocol-TX-Module/issues/543

howels commented 2 years ago

@MJ666 @TheRealMoeder since this PR merge nightly builds have been broken, please can you check what happened?

MJ666 commented 2 years ago

Sorry dot have any control over the nightly build process. Was also asking already in the forum.

howels commented 2 years ago

Sorry dot have any control over the nightly build process. Was also asking already in the forum.

Can you revert the PR and check that all build targets are working locally before merging again?

MJ666 commented 2 years ago

As you may see this PR passed all checks and should build without issues. It also builds without issues in my private build environment. Anyhow I'm not able to revert this PR since I dont have the permission to do so.

howels commented 2 years ago

Any ideas why the devo6 image build failed? https://travis-ci.org/github/DeviationTX/deviation/builds/774621651

howels commented 2 years ago

No idea why it fails - builds fine locally here for devo6 but I notice that Trusty 14.04 is being used as the base image which is EOL now.

gdenton61 commented 2 years ago

My local build (on Ubuntu 20.04.3) the devo6 builds fine but the devo7e fails with the same error as shown on lines 1416 & 1417 of https://travis-ci.org/github/DeviationTX/deviation/builds/774621651 referenced above:

arm-none-eabi-ld: objs/devo7e/frskyx_cc2500.elf section .bss' will not fit in regionram' arm-none-eabi-ld: region `ram' overflowed by 18 bytes

MJ666 commented 2 years ago

Mhhh, it really looks to be the FrSky protocol does not fit anymore into memory of the low end Devo's. There was quite some optimization done for the v2.x protocol update to make it fit. I guess there are now no more other option for optimisation than excluding this fix for the Devo7 builds. Not sure why it builds successful during merge in the first place?

howels commented 2 years ago

Can we disable it for limited-flash targets for now in order to get nightly builds rolling again and optimise for space later if that requires time and research @MJ666 ?

MJ666 commented 2 years ago

Added a new PR to apply the XM+ fix only to non modular targets. #1015