DeviceFarmer / adbkit

A pure Node.js client for the Android Debug Bridge.
Other
223 stars 50 forks source link

Throw error if DELETE_FAILED_DEVICE_POLICY_MANAGER is sent #513

Closed tburakdemir closed 10 months ago

tburakdemir commented 10 months ago

Hi, Some of our client's apk can not be installed due to DELETE_FAILED_DEVICE_POLICY_MANAGER error of adb. In codebase returns true either way so we can't catch the apk is actually uninstalled.

This apk has device admin permission. If it is authorized then it can not be uninstalled regular way. First we must disable policy with "adb shell pm disable-user pkg" then uninstall it with normal way.

I share you an example apk has this permission: https://apkcombo.com/device-administrator/io.ebeck.jacob.deviceadmin/download/apk

After the installation apk; Open the app Click the Enable Device Admin It opens android permision pop-up Click activate.

Then you could not uninstall the apk in normal way. It responds with "Failure [DELETE_FAILED_DEVICE_POLICY_MANAGER]" So In the code i made some changes that throws an error if this event occurs. So in my workspace i can catch it then solved like above solution.

`import { Adb } from './src';

const client = Adb.createClient();

const udid = 'emulator-5554'; const element = 'io.ebeck.jacob.deviceadmin'; const device = client.getDevice(udid);

async function uninstall() { try { const result = await device.uninstall(element); console.log(result); } catch (error: any) { console.log(error.message); await device.shell("pm disable-user " + element) .then(Adb.util.readAll) .then((output) => { console.log('[%s] %s', device.serial, output.toString().trim()); }) const result = await device.uninstall(element); console.log(result); } }

uninstall(); `

image

https://developer.android.com/reference/android/app/admin/DevicePolicyManager https://stackoverflow.com/questions/13911444/disable-deviceadmin-from-shell

koral-- commented 10 months ago

LGTM, but the sign-off is missing.

tburakdemir commented 10 months ago

signed off, thank you

tburakdemir commented 7 months ago

How can I get this pr from npm. Is there any planning of version update?

koral-- commented 7 months ago

Sorry for the delay, I've just released version 3.2.6.