search

DeviceFarmer / adbkit

A pure Node.js client for the Android Debug Bridge.
Other
239 stars 56 forks source link

Fix leaked promise in pull #530

Closed dfriederich closed 2 months ago

dfriederich commented 2 months ago

When pulling, the second adb sync transfer was just ignored, causing a warning to be logged for every pull operation.

2024-09-11T20:10:52.421Z root ERROR (node:174306) Warning: a promise was created in a handler at node:internal/async_hooks:130:17 but was not returned from it, see http://goo.gl/rRqMUw at new Promise (/..../vendors-node_modules_drivelist_build_Release_drivelist_node-node_modules_devicefarmeradbkit-505406.js:50543:10)

Fixing this by actually returning the promise.

koral-- commented 2 months ago

Could you sync your branch? I've just fixed the CI config, so PR check should work.

dfriederich commented 2 months ago

thanks for the validation setup fix :-)