DeviceFarmer / minicap

Stream real-time screen capture data out of Android devices.
Other
293 stars 76 forks source link

support Android 12 for the minicap.so building. #30

Closed JesseCodeBones closed 3 years ago

pcrepieux commented 3 years ago

Thanks guys for the PR. I was giving a look to https://github.com/DeviceFarmer/minicap/pull/29 this morning. @JesseCodeBones, may I ask you to update the main Makefile and fix the blank line. That would be nice. You also have to add a sign-off. Otherwise, works great on my Pixel3XL as well 👍

koral-- commented 3 years ago

Only sign-of is missing now

JesseCodeBones commented 3 years ago

@pcrepieux @koral-- I added the commits and signed off the commits. and I also mentioned there missed the Android 30 and apart of Android 29. I think it is not suitable to fix in this PR, maybe another PR is needed. please kindly review the code and verify the result. Thank you very much.