search

DevilXD / TwitchDropsMiner

An app that allows you to AFK mine timed Twitch drops, with automatic drop claiming and channel switching.
MIT License
1.6k stars 156 forks source link

[Feature Request]Hide games that don't drop treasure in the channel list or show only the games in the priority list #33

Open itinybad opened 2 years ago

itinybad commented 2 years ago

Hide games that don't drop treasure in the channel list or show only the games in the priority list

DevilXD commented 2 years ago

Hello o/

I'm assuming you mean this as a purely visual filtering feature? Because right now, the channel list represents 1:1 to application's memory, including which channels are being tracked, their status, game they're playing, etc., including the order of the channels on the list, matching the order of the channel objects in-memory. This order is considered when picking the next channel to watch after the one currently being watched goes offline.

DevilXD commented 2 years ago

I've looked into the mechanics of making this possible. The issue is, the table structure that's used to display the channels, has no easy option to "keep things ordered" once I start hiding rows from it. As in, "hiding" a row involves removing it from the current position, and all other rows change their indexes afterwards - reinserting at the same index is not possible since the list can have arbitrary rows removed, and the indexes shift every time that happens, so reinserting wouldn't happen at the same place the original row was removed from. This wasn't an issue with the inventory viewer since it had a "hide" option that'd remember the original index internally. The channel list was never designed with hiding in mind.

Is there a real need for this feature to exist? I mean, all online channels are already kept near the top of the list, their games are already displayed. Is it really a trouble to sift through the list, looking for a channel to watch? I'd appreciate other people's input on this topic here.

itinybad commented 2 years ago

Thanks for your response, in fact this feature is not necessary for most users, but it can be handy to switch to a given game if the drop activity of a game is about to end, because for me the list of games shown in the list includes games I have not added to the priority list, many and hard to identify. If the hidden feature is hard to add, is it possible to add a different color for each item of the game list, for example, the channel text color that supports drop or the background color of the item can be changed to a prominent color, unfortunately I'm not a Python developer and can't help you with your development. Thanks again for your response.

DevilXD commented 2 years ago

I see. The colors solution is also possible, but just as tricky to implement (maybe only a little less). The thing is, the indexes issue I just mentioned could be helped with some index tracking, but since it'd take time (I have IRL work to do) and additional code to implement, I'd like to hear some feedback from other people on this request first. Anything from "I'd also like this feature to exist" to filtering option suggestions (like the "drops enabled" or "priority list games" ones you suggested) will be appreciated.

Until then, the status of this issue is "maybe, once more people would like this to exist". Same applies to #32.