search

DevilXD / TwitchDropsMiner

An app that allows you to AFK mine timed Twitch drops, with automatic drop claiming and channel switching.
MIT License
1.64k stars 161 forks source link

Simplified Chinese translation not working #584

Closed zhangminghao1989 closed 3 hours ago

zhangminghao1989 commented 5 hours ago

Simplified Chinese translation not working

DevilXD commented 4 hours ago

Hello,

Please specify how exactly is it "not working". The miner displays the default English translation, even if you select Simplified Chinese? Is this related to #585?

JourneyOver commented 3 hours ago

This could be due to the fact that when @Suz1e made #582 they screwed up and added a extra } which is causing a parse error.

zhangminghao1989 commented 3 hours ago

585 fix

JourneyOver commented 3 hours ago

I mean you still have a parse error for the Simplified Chinese translation file regardless of the #585 PR, so... xD

DevilXD commented 2 hours ago

@zhangminghao1989 You can use https://jsonformatter.curiousconcept.com to validate the JSON before submitting it as a PR. It's also a good reminder for me to verify this as well, before I merge a translation update.

Fixed in https://github.com/DevilXD/TwitchDropsMiner/commit/9ee872f4754f3a88043c5f94358bc22763d6058d.