search

DevinBayly / neuro-choro

Live tool accessible at
https://devinbayly.github.io/neuro-choro
0 stars 0 forks source link

Region Color Slider: dropdown does not always appear next to slider #10

Closed dkp closed 4 years ago

dkp commented 4 years ago

A dropdown selector should appear next to the region color column slider. It does not always appear and especially likely to be missing on the first pane.

DevinBayly commented 4 years ago

Just a thought. The drop down is populated by the csv that is uploaded, and that data isn't provided immediately on page load. The drop down selector is created upon loading the csv. Would it make more sense if the selection drop down was present but unpopulated with options initially?

The region boundaries are available right when the page loads and a default slice is displayed so the slice slider is included on startup.

The part about how the dropdowns position can change after it first appears, this is related to issue #8, and I believe I know how to fix that as well.

dkp commented 4 years ago

I think I'd have to see it to know what you mean. But let's try it.

From: Devin Bayly notifications@github.com Sent: Friday, December 13, 2019 5:46 PM To: DevinBayly/neuro-choro neuro-choro@noreply.github.com Cc: Patterson, Dianne K - (dkp) dkp@email.arizona.edu; Author author@noreply.github.com Subject: Re: [DevinBayly/neuro-choro] Region Color Slider: dropdown does not always appear next to slider (#10)

Just a thought. The drop down is populated by the csv that is uploaded, and that data isn't provided immediately on page load. The drop down selector is created upon loading the csv. Would it make more sense if the selection drop down was present but unpopulated with options initially?

The region boundaries are available right when the page loads and a default slice is displayed so the slice slider is included on startup.

The part about how the dropdowns position can change after it first appears, this is related to issue #8https://github.com/DevinBayly/neuro-choro/issues/8, and I believe I know how to fix that as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/DevinBayly/neuro-choro/issues/10?email_source=notifications&email_token=AAHLUQEIJMOQBCFZJQ4VFP3QYQUGFA5CNFSM4J2DDIC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3VB5Y#issuecomment-565661943, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHLUQCCTSJVHKOZB6ZEQOTQYQUGFANCNFSM4J2DDICQ.

DevinBayly commented 4 years ago

Can you take a look at the most recent notebook revision? I believe this issue is resolved. https://alpha.iodide.io/notebooks/3446/?

dkp commented 4 years ago

This is great. You have solved the problem...but see additional issue r colors not showing up.