search

DevinR528 / bo_autosplitter

1 stars 0 forks source link

Autosplitter splitting multiple times on file load after save/quit #3

Closed MrSir71 closed 1 month ago

MrSir71 commented 1 month ago

When you load back into your file after a s/q, 4 or 5 splits go off everytime. It is usually a consistent amount in that range in a given run.

I am not sure how this is working now, but one way it could be remedied is by adding ordered autosplits. That way, instead of looking for any of the checked autosplits, it just looks for the next one and hopefully doesn't find it on file load. | Maybe the issue can be corrected with the current paradigm but I'm not sure how you are checking the pointers on file load right now.

MrSir71 commented 1 month ago

Vysuals is having this problem as well

DevinR528 commented 1 month ago

I fixed this by tracking what splits have been completed and not re-splitting when they are already split. This will not work if LiveSplit has to be restarted (I would consider having to restart LiveSplit a restart to the run also maybe?).

This will be closed via https://github.com/DevinR528/bo_autosplitter/commit/0fbd8a50638e1847ad89363dd4b3063811b66a40 once I have confirmed in discord.

MrSir71 commented 1 month ago

that sounds like a good solution! I think if livesplit crashes yeah it would be asking a lot to be able to restart it and continue, so no big deal. as long as we can get an IGT for the run the split times don't matter as much. thanks! will test tomorrow

DevinR528 commented 1 month ago

If this happens again feel free to reopen.