search

DevinWalker / wp-rollback

Rollback any WordPress.org plugin or theme to a previous (or newer) version.
https://wprollback.com
81 stars 22 forks source link

Broken in WP 4.9.x #78

Closed ginsterbusch closed 7 months ago

ginsterbusch commented 7 months ago

Bug Report

User Story

Tested it on ClassicPress 1.7.x, which is an active fork of WP 4.9.x (with a few security backports from WP 5) and ClassicPress v2-nightly (which is a refork based on WP 6.2 without Gutenberg, everything else is the same). Expected it to work flawlessly, but is broken when trying to rollback a plugin or theme.

Current Behavior

When clicking on the 'rollback' for any plugin, you get redirected to the updates screen, but aside of the usual Admin Navigation, the page is empty. Query monitor lights up with missing script and style errors instantly.

Expected Behavior

A working solution, despite not being able to load scripts and styles not existing in WP 4.9.x.

Bug Type

Steps to Reproduce

  1. Install WP 4.9.x OR ClassicPress 1.7.x
  2. Install plugin, and some others for testing purposes, eg. Instant Images in its current version, which doesnt work, because it requires react and all the other gutenborg components, but works in WP 4.9.x / CP 1.7.x with version 4.2.0
  3. Try to rollback Instant Images from 6.x to 4.2.0

Visuals

Possible Solution

Downgrade to 1.7.3.

Related

Acceptance Criteria

Environment

Server: some Linux or Unix Client: all browsers (its a server-side issue) WP: 4.9 CP: 1.7.x, v2-rc1 / nightly (latest)

DevinWalker commented 7 months ago

Hey @ginsterbusch, the 2.0+ versions of WP Rollback won't work with 4.8.x or ClassicPress because I'm using the WordPress components in the new React-built interface. A potential workaround is to use the 1.7.x versions.

My apologies; I just realized as well that the minimum WordPress requirement in 2.0+ was still set to WP 4.8, and this is misleading. I updated it in this commit: 74945b514187394c4d12f4ffec100538a2ef169b

You can find past releases here: https://github.com/DevinWalker/wp-rollback/releases

Thanks for your interest

ginsterbusch commented 6 months ago

Ok, then I just gonna fork it and create a ClassicPress-compatible version. In theory, it should also work with WP 4.9.x, but that is not my main focus.