search

DevoAbhi / WhatsSend-Frontend

Frontend of the WhatsSend App. It uses the api created in the WhatsSend-Backend repository.
https://whatssends.netlify.app/
1 stars 8 forks source link

Added Form Layout #18

Closed Krunal-Karena closed 2 years ago

Krunal-Karena commented 2 years ago

Added form layout in saperate folder. please review my PR.

DevoAbhi commented 2 years ago

Great work! 1) But you can place this directly in index.html because the page will load from there. Also, please look into the id names that are given to the input that are used in the script.js file. 2) You have given time as input which is great for the UI, but as of now breaks the app. In backend we are sending the time in 24 hrs time. Can you fix that?

Krunal-Karena commented 2 years ago

Ok,i will fix it.

On Mon, Oct 10, 2022, 11:20 PM Abhinab Roy @.***> wrote:

Great work!

  1. But you can place this directly in index.html because the page will load from there. Also, please look into the id names that are given to the input that are used in the script.js file.
  2. You have given time as input which is great for the UI, but as of now breaks the app. In backend we are sending the time in 24 hrs time. Can you fix that?

— Reply to this email directly, view it on GitHub https://github.com/DevoAbhi/WhatsSend-Frontend/pull/18#issuecomment-1273642740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AX2BAPOI4247U3CYTYMBBKDWCRJOPANCNFSM6AAAAAARBRQXFE . You are receiving this because you authored the thread.Message ID: @.***>

Krunal-Karena commented 2 years ago

For 2nd point time as input already have 24 hrs time formate.

Krunal-Karena commented 2 years ago

I tried to make changes in script.js but i am not able to solve it because i don't know javascript much. but if you can solve than it will be better to have date & time as input because user like it more. it's your choice if you want input as before than i will change it.

DevoAbhi commented 2 years ago

Ok, do one thing. 1) Put the Form.html in index.html with previous input id names in your inputs. 2) Connect the css file to index.html 3) I will look into the time part

Krunal-Karena commented 2 years ago

Done

DevoAbhi commented 2 years ago

Great design and work!

Some improvements: 1) The recipient's name has been changed to recipient's number in master branch 2) Change the id from "name" to "number" 2) Remove the send button as the msg is sent after the user links whatsapp after getting the QR. 3) Add type="button" in get qr button as that would prevent the page to reload.

Krunal-Karena commented 2 years ago

If everything is ok then merge & label it as Hacktoberfest accepted.

DevoAbhi commented 2 years ago

If everything is ok then merge & label it as Hacktoberfest accepted.

I mentioned two changes above.

I am labelling it.

Krunal-Karena commented 2 years ago

I think i have done all the changes which you told.

DevoAbhi commented 2 years ago

I think i have done all the changes which you told.

1) Which app.css are you linking? 2) qr display also needs a padding bottom div like everything else

DevoAbhi commented 2 years ago

I think i have done all the changes which you told.

  1. Which app.css are you linking?
  2. qr display also needs a padding bottom div like everything else

Ok, leave it. I'll do it.

DevoAbhi commented 2 years ago

Great work!