Open divyanshiet opened 2 years ago
One contributor is working on the form, when he's done I can assign you this.
ok
@divyanshiet Now the previous work has been deployed. Now you can look if you can improve anything. Thank you.
then assign it, i will give the design part in it @DevoAbhi
@divyanshiet Go ahead.
@divyanshiet Go ahead.
labels!!
@DevoAbhi do you have idea regarding how you want to look your webpage or i will have to design by own
If you ask me: 1) The current form looks good. 2) It needs a spinner loader which starts after the user has clicked the get qr button and stops after the qr has been displayed. 3) Dark mode appropriate contrast colors (may be looked afterwards)
Would love your suggestions on this.
Can u pls show the current form?? On Wed, 12 Oct 2022 at 10:06 PM, Abhinab Roy @.***> wrote:
If you ask me:
- The current form looks good.
- It needs a spinner loader which starts after the user has clicked the get qr button and stops after the qr has been displayed.
- Dark mode appropriate contrast colors (may be looked afterwards)
Would love your suggestions on this.
— Reply to this email directly, view it on GitHub https://github.com/DevoAbhi/WhatsSend-Frontend/issues/9#issuecomment-1276453428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ7OUWQ3GH3V4ZORMP4DBTWC3SKHANCNFSM6AAAAAARBBMTAU . You are receiving this because you were mentioned.Message ID: @.***>
I think spinner loader time of display depend upon the network speed of the user na??
On Wed, 12 Oct 2022 at 10:12 PM, divyansh pandey @.***> wrote:
Can u pls show the current form??
On Wed, 12 Oct 2022 at 10:06 PM, Abhinab Roy @.***> wrote:
If you ask me:
- The current form looks good.
- It needs a spinner loader which starts after the user has clicked the get qr button and stops after the qr has been displayed.
- Dark mode appropriate contrast colors (may be looked afterwards)
Would love your suggestions on this.
— Reply to this email directly, view it on GitHub https://github.com/DevoAbhi/WhatsSend-Frontend/issues/9#issuecomment-1276453428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ7OUWQ3GH3V4ZORMP4DBTWC3SKHANCNFSM6AAAAAARBBMTAU . You are receiving this because you were mentioned.Message ID: @.***>
The QR code is received from the backend. Its takes time for the backend to create a QR code and send it. During that time, nothing is displayed on the screen. Instead of that, a spinner would denote the user that QR code is working up.
Can u pls show the current form?? … On Wed, 12 Oct 2022 at 10:06 PM, Abhinab Roy @.> wrote: If you ask me: 1. The current form looks good. 2. It needs a spinner loader which starts after the user has clicked the get qr button and stops after the qr has been displayed. 3. Dark mode appropriate contrast colors (may be looked afterwards) Would love your suggestions on this. — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ7OUWQ3GH3V4ZORMP4DBTWC3SKHANCNFSM6AAAAAARBBMTAU . You are receiving this because you were mentioned.Message ID: @.>
You can pull the latest changes from the master, or click on the link mentioned in the description of the repo to check.
The QR code is received from the backend. Its takes time for the backend to create a QR code and send it. During that time, nothing is displayed on the screen. Instead of that, a spinner would denote the user that QR code is working up.
ok i will try to make it
Can u pls show the current form?? … On Wed, 12 Oct 2022 at 10:06 PM, Abhinab Roy @.**> wrote: If you ask me: 1. The current form looks good. 2. It needs a spinner loader which starts after the user has clicked the get qr button and stops after the qr has been displayed. 3. Dark mode appropriate contrast colors (may be looked afterwards) Would love your suggestions on this. — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ7OUWQ3GH3V4ZORMP4DBTWC3SKHANCNFSM6AAAAAARBBMTAU . You are receiving this because you were mentioned.Message ID: @.**>
You can pull the latest changes from the master, or click on the link mentioned in the description of the repo to check.
Ya I saw it, it was looking good, but i think header section (whatssend) and footer section (copyright and all that) should be stick on the webpage...do give your confirmation on this should I change it?
What do you mean "should be stick on the webpage"?
Also, you can change the font style on the webpage. My suggestion would be "Merriweather".
It means,currently when you scroll down your web page than that part will go up along with all,but when we stick it then that part will always be there whenever you scroll.... For more clearance search position:sticky attribute on google
On Thu, 13 Oct 2022 at 10:31 AM, Abhinab Roy @.***> wrote:
What do you mean "should be stick on the webpage"?
Also, you can change the font style on the webpage. My suggestion would be "Merriweather".
— Reply to this email directly, view it on GitHub https://github.com/DevoAbhi/WhatsSend-Frontend/issues/9#issuecomment-1277034225, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQ7OUQUMBURDQPQMX43GUDWC6JTVANCNFSM6AAAAAARBBMTAU . You are receiving this because you were mentioned.Message ID: @.***>
Yeah I know what position: sticky is. I was saying how would you implement that. I mean, as there is no navbar, at which position would you stick it.
So will you stick the WhatsSend title keeping a little padding above the title, or stick it where it already is?
I want to make site good looking by adding required CSS in it, such that it will look more attracting and in much better way than now