search

DevoLearn / devolearn

Accelerate data driven research on embryos with deep learning models :microscope:
MIT License
43 stars 30 forks source link

Partial conversion of cv2 IO operations to imageio #45

Closed aswarth123 closed 3 years ago

aswarth123 commented 3 years ago

@Mayukhdeb There are a few concerns that I am facing 1) If we are using the imageio for reading the image the issue is with the datatype in which it is stored it actually requires much more modification of the code like changing a line would not be enough 2) The same thing happens for reading and writing of the videos as well. For now I have just made the modifications to those functions which are convertible directly from cv2 to imageio. If you want me to do that as well then it will require a little bit more time. This pr partially fixes #43

Mayukhdeb commented 3 years ago

Hi @aswarth123 , thanks for your PR. It seems like the changes that you made did not make it through the unit tests. You might want to check the build log in order to try and fix this failure.

Mayukhdeb commented 3 years ago

@aswarth123 thanks for the insight! Feel free to take your time. If you face any more issues, I'll be here to help.

Mayukhdeb commented 3 years ago

For now I'll have to close this PR, we can reopen this once you've completetely solved the issue. I also encourage you to work on the other issues which will be coming in the next few days.